VDA unittest: fix ~GLRenderingVDAClient crash in debug build.

VDA unittest: fix ~GLRenderingVDAClient crash in debug build.

This was introduced by 386d72414e61c5e8155b66e2986fa0039f4b010a.
GLRenderingVDAClient uses ClientStateNotification and must be
deleted first.

BUG=654429
TEST=Run VDA unittest on peach pi.

Committed: https://crrev.com/dc834a8f5707c31894ddebc8f12faf2cd4d2d434
Cr-Commit-Position: refs/heads/master@{#424366}

[wuchengli, 2016-10-11 02:22:42]

wuchengli@chromium.org changed reviewers:
+ owenlin@chromium.org

[wuchengli, 2016-10-11 02:22:42]

PTAL

[wuchengli, 2016-10-11 02:24:47]

https://codereview.chromium.org/2407863002/diff/1/media/gpu/video_decode_acce...
File media/gpu/video_decode_accelerator_unittest.cc (right):

https://codereview.chromium.org/2407863002/diff/1/media/gpu/video_decode_acce...
media/gpu/video_decode_accelerator_unittest.cc:390: // Doesn't take ownership of
|rendering_helper| or |note|, which must outlive
FYI. |note| should outlive GLRenderingVDAClient.

[Owen Lin, 2016-10-11 03:01:49]

On 2016/10/11 02:24:47, wuchengli wrote:
>
https://codereview.chromium.org/2407863002/diff/1/media/gpu/video_decode_acce...
> File media/gpu/video_decode_accelerator_unittest.cc (right):
> 
>
https://codereview.chromium.org/2407863002/diff/1/media/gpu/video_decode_acce...
> media/gpu/video_decode_accelerator_unittest.cc:390: // Doesn't take ownership
of
> |rendering_helper| or |note|, which must outlive
> FYI. |note| should outlive GLRenderingVDAClient.

lgtm

FYI. The behavior is actually changed by a recent change:
https://codereview.chromium.org/2371783002/diff/140001/media/gpu/video_decode...

[wuchengli, 2016-10-11 03:05:04]

On 2016/10/11 03:01:49, Owen Lin wrote:
> On 2016/10/11 02:24:47, wuchengli wrote:
> >
>
https://codereview.chromium.org/2407863002/diff/1/media/gpu/video_decode_acce...
> > File media/gpu/video_decode_accelerator_unittest.cc (right):
> > 
> >
>
https://codereview.chromium.org/2407863002/diff/1/media/gpu/video_decode_acce...
> > media/gpu/video_decode_accelerator_unittest.cc:390: // Doesn't take
ownership
> of
> > |rendering_helper| or |note|, which must outlive
> > FYI. |note| should outlive GLRenderingVDAClient.
> 
> lgtm
> 
> FYI. The behavior is actually changed by a recent change:
>
https://codereview.chromium.org/2371783002/diff/140001/media/gpu/video_decode...
I know. I mentioned it in the change description.

[wuchengli, 2016-10-11 03:05:14]

The CQ bit was checked by wuchengli@chromium.org

[commit-bot: I haz the power, 2016-10-11 03:05:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wuchengli, 2016-10-11 03:13:52]

The CQ bit was unchecked by wuchengli@chromium.org

[wuchengli, 2016-10-11 04:14:35]

The CQ bit was checked by wuchengli@chromium.org

[commit-bot: I haz the power, 2016-10-11 04:14:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 04:20:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-11 04:22:41]

Description was changed from

==========
VDA unittest: fix ~GLRenderingVDAClient crash in debug build.

This was introduced by 386d72414e61c5e8155b66e2986fa0039f4b010a.
GLRenderingVDAClient uses ClientStateNotification and must be
deleted first.

BUG=654429
TEST=Run VDA unittest on peach pi.
==========

to

==========
VDA unittest: fix ~GLRenderingVDAClient crash in debug build.

This was introduced by 386d72414e61c5e8155b66e2986fa0039f4b010a.
GLRenderingVDAClient uses ClientStateNotification and must be
deleted first.

BUG=654429
TEST=Run VDA unittest on peach pi.

Committed: https://crrev.com/dc834a8f5707c31894ddebc8f12faf2cd4d2d434
Cr-Commit-Position: refs/heads/master@{#424366}
==========

[commit-bot: I haz the power, 2016-10-11 04:22:42]

Patchset 1 (id:??) landed as
https://crrev.com/dc834a8f5707c31894ddebc8f12faf2cd4d2d434
Cr-Commit-Position: refs/heads/master@{#424366}