Introduce BookmarkClient interface to abstract embedder

chrome/browser/bookmarks/bookmark_test_helpers.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BOOKMARKS_BOOKMARK_TEST_HELPERS_H_
 #define CHROME_BROWSER_BOOKMARKS_BOOKMARK_TEST_HELPERS_H_
 
 #include <string>
 
+#include "components/bookmarks/core/browser/bookmark_client.h"
+
 class BookmarkModel;
 class BookmarkNode;
 class Profile;
 
 namespace test {
 
+class TestBookmarkClient : public BookmarkClient {

[tfarina, 2014/04/22 21:19:58]

Also, no. Leave this file for helper utility test functions. Please, move this
into test_bookmark_client.h

[sdefresne, 2014/04/23 16:10:18]

Done.

+ public:
+  // Create a BookmarkClient using the this object as its client.
+  BookmarkModel* CreateModel();
+
+  virtual base::CancelableTaskTracker::TaskId GetFaviconImageForURL(

[tfarina, 2014/04/22 21:19:58]

Group the overrides, can you also override everything in the private section?
And add a comment like: // BookmarkClient:

[sdefresne, 2014/04/23 16:10:18]

Done.

+      const GURL& page_url,
+      int icon_types,
+      int desired_size_in_dip,
+      const FaviconImageCallback& callback,
+      base::CancelableTaskTracker* tracker) OVERRIDE;
+
+  virtual bool SupportsTypedCountForNodes() OVERRIDE;
+
+  virtual void GetTypedCountForNodes(
+      const NodeSet& nodes,
+      NodeTypedCountPairs* node_typed_count_pairs) OVERRIDE;
+
+  virtual void RecordAction(const base::UserMetricsAction& action) OVERRIDE;
+
+ private:
+  virtual void OnLoad() OVERRIDE;
+
+  virtual void OnClearStore() OVERRIDE;
+
+  virtual void NotifyHistoryAboutRemovedBookmarks(
+      const std::set<GURL>& removed_bookmark_urls) OVERRIDE;
+};

[tfarina, 2014/04/22 21:19:58]

DISALLOW_COPY_AND_ASSIGN

[sdefresne, 2014/04/23 16:10:18]

Done.

+
 // Blocks until |model| finishes loading.
 void WaitForBookmarkModelToLoad(BookmarkModel* model);
 void WaitForBookmarkModelToLoad(Profile* profile);
 
 // Return the descendants of |node| as a string useful for verifying node
 // modifications. The format of the resulting string is:
 //
 //           result = node " " , { node " " }
 //             node = bookmark title | folder
 //           folder = folder title ":[ " { node " " } "]"
@@ skipping 12 matching lines @@
 // are appended to the end of node's existing subnodes, if any.
 // |model| must be the model of which |node| is a member.
 // NOTE: The string format is very rigid and easily broken if not followed
 //       exactly (since we're using a very simple parser).
 void AddNodesFromModelString(BookmarkModel* model,
                              const BookmarkNode* node,
                              const std::string& model_string);
 }  // namespace test
 
 #endif  // CHROME_BROWSER_BOOKMARKS_BOOKMARK_TEST_HELPERS_H_