Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9776)

Unified Diff: content/browser/frame_host/frame_tree.cc

Issue 2426503002: Make printing work better with OOPIF. (Closed)
Patch Set: Fix build, nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/frame_tree.cc
diff --git a/content/browser/frame_host/frame_tree.cc b/content/browser/frame_host/frame_tree.cc
index 370946e428b8d77be1edc2b815a36d53b1b0ce29..b51cee42ad2b89ec8358903d699dce0f512aa46a 100644
--- a/content/browser/frame_host/frame_tree.cc
+++ b/content/browser/frame_host/frame_tree.cc
@@ -109,7 +109,7 @@ FrameTree::FrameTree(Navigator* navigator,
std::string(),
std::string(),
FrameOwnerProperties())),
- focused_frame_tree_node_id_(-1),
+ focused_frame_tree_node_id_(FrameTreeNode::kFrameTreeNodeInvalidId),
nasko 2016/11/02 04:50:37 I love that you are fixing code and style along th
Lei Zhang 2016/11/08 11:13:22 Ack. I'll re-review my own CL and strip off some o
load_progress_(0.0) {}
FrameTree::~FrameTree() {
@@ -381,7 +381,7 @@ void FrameTree::ReleaseRenderViewHostRef(RenderViewHostImpl* render_view_host) {
void FrameTree::FrameRemoved(FrameTreeNode* frame) {
if (frame->frame_tree_node_id() == focused_frame_tree_node_id_)
- focused_frame_tree_node_id_ = -1;
+ focused_frame_tree_node_id_ = FrameTreeNode::kFrameTreeNodeInvalidId;
// No notification for the root frame.
if (!frame->parent()) {

Powered by Google App Engine
This is Rietveld 408576698