Make printing work better with OOPIF.

content/browser/frame_host/frame_tree.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/frame_tree.h"
 
 #include <stddef.h>
 
 #include <queue>
 #include <utility>
@@ skipping 91 matching lines @@
                               render_frame_delegate,
                               render_widget_delegate,
                               manager_delegate,
                               nullptr,
                               // The top-level frame must always be in a
                               // document scope.
                               blink::WebTreeScopeType::Document,
                               std::string(),
                               std::string(),
                               FrameOwnerProperties())),
-      focused_frame_tree_node_id_(-1),
+      focused_frame_tree_node_id_(FrameTreeNode::kFrameTreeNodeInvalidId),

[nasko, 2016/11/02 04:50:37]

I love that you are fixing code and style along the way, but it will be a
smaller diff to review and keep track of if these were committed separately.

[Lei Zhang, 2016/11/08 11:13:22]

Ack. I'll re-review my own CL and strip off some of the random cleanups in an
upcoming patchset.

       load_progress_(0.0) {}
 
 FrameTree::~FrameTree() {
   delete root_;
   root_ = nullptr;
 }
 
 FrameTreeNode* FrameTree::FindByID(int frame_tree_node_id) {
   for (FrameTreeNode* node : Nodes()) {
     if (node->frame_tree_node_id() == frame_tree_node_id)
@@ skipping 251 matching lines @@
   CHECK_GT(iter->second->ref_count(), 0);
   iter->second->decrement_ref_count();
   if (iter->second->ref_count() == 0) {
     iter->second->ShutdownAndDestroy();
     render_view_host_map_.erase(iter);
   }
 }
 
 void FrameTree::FrameRemoved(FrameTreeNode* frame) {
   if (frame->frame_tree_node_id() == focused_frame_tree_node_id_)
-    focused_frame_tree_node_id_ = -1;
+    focused_frame_tree_node_id_ = FrameTreeNode::kFrameTreeNodeInvalidId;
 
   // No notification for the root frame.
   if (!frame->parent()) {
     CHECK_EQ(frame, root_);
     return;
   }
 
   // Notify observers of the frame removal.
   if (!on_frame_removed_.is_null())
     on_frame_removed_.Run(frame->current_frame_host());
@@ skipping 77 matching lines @@
   // This is only used to set page-level focus in cross-process subframes, and
   // requests to set focus in main frame's SiteInstance are ignored.
   if (instance != root_manager->current_frame_host()->GetSiteInstance()) {
     RenderFrameProxyHost* proxy =
         root_manager->GetRenderFrameProxyHost(instance);
     proxy->Send(new InputMsg_SetFocus(proxy->GetRoutingID(), is_focused));
   }
 }
 
 }  // namespace content