Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2426503002: Make printing work better with OOPIF. (Closed)
Patch Set: Fix build, nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index f0d8d06376d69286e96bfca5db50aa2f39ee9ff3..04f1f6defbe92cc66cf4303c331ef1bc7f9c7b72 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -165,6 +165,7 @@ class CONTENT_EXPORT RenderFrameHostImpl
int GetProxyCount() override;
void FilesSelectedInChooser(const std::vector<FileChooserFileInfo>& files,
FileChooserParams::Mode permissions) override;
+ bool HasSelection() override;
void RequestTextSurroundingSelection(
const TextSurroundingSelectionCallback& callback,
int max_length) override;
@@ -266,7 +267,7 @@ class CONTENT_EXPORT RenderFrameHostImpl
// distinguished by owning a RenderWidgetHost, which manages input events
// and painting for this frame and its contiguous local subtree in the
// renderer process.
- bool is_local_root() { return !!render_widget_host_; }
+ bool is_local_root() const { return !!render_widget_host_; }
// Returns the RenderWidgetHostImpl attached to this frame or the nearest
// ancestor frame, which could potentially be the root. For most input
@@ -1041,6 +1042,8 @@ class CONTENT_EXPORT RenderFrameHostImpl
// called (no pending instance should be set).
bool should_reuse_web_ui_;
+ bool has_selection_;
nasko 2016/11/02 04:50:37 nit: Put a small comment on what the meaning of th
Lei Zhang 2016/11/08 11:13:22 Done.
+
// PlzNavigate: The LoFi state of the last navigation. This is used during
// history navigation of subframes to ensure that subframes navigate with the
// same LoFi status as the top-level frame.

Powered by Google App Engine
This is Rietveld 408576698