|
|
Created:
4 years, 2 months ago by Alexei Svitkine (slow) Modified:
4 years, 2 months ago Reviewers:
rkaplow CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd histograms that monitor variation seed fetching from Java.
Depends on https://codereview.chromium.org/2435813002/ which
is moving the implementation of CachedMetrics to base from chrome/.
BUG=632199
Committed: https://crrev.com/6c139a2b0943224d42b1402584ab3c21d28d5232
Cr-Commit-Position: refs/heads/master@{#426689}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove a #
Depends on Patchset: Messages
Total messages: 27 (19 generated)
The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Description was changed from ========== [X2] Add histograms that monitor variation seed fetching from Java. Depends on https://codereview.chromium.org/2435813002/ which is moving the implementation of CachedMetrics to base from chrome/. BUG=632199 ========== to ========== Add histograms that monitor variation seed fetching from Java. Depends on https://codereview.chromium.org/2435813002/ which is moving the implementation of CachedMetrics to base from chrome/. BUG=632199 ==========
The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:40001) has been deleted
asvitkine@chromium.org changed reviewers: + rkaplow@chromium.org
lgtm https://codereview.chromium.org/2426343004/diff/60001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2426343004/diff/60001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:67680: + The latency of a fetching an initial variations seed during Android Chrome remove 'a'
https://codereview.chromium.org/2426343004/diff/60001/tools/metrics/histogram... File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2426343004/diff/60001/tools/metrics/histogram... tools/metrics/histograms/histograms.xml:67680: + The latency of a fetching an initial variations seed during Android Chrome On 2016/10/20 17:32:55, rkaplow wrote: > remove 'a' Done.
The CQ bit was checked by asvitkine@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2426343004/#ps80001 (title: "Remove a")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Add histograms that monitor variation seed fetching from Java. Depends on https://codereview.chromium.org/2435813002/ which is moving the implementation of CachedMetrics to base from chrome/. BUG=632199 ========== to ========== Add histograms that monitor variation seed fetching from Java. Depends on https://codereview.chromium.org/2435813002/ which is moving the implementation of CachedMetrics to base from chrome/. BUG=632199 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:80001)
Message was sent while issue was closed.
On 2016/10/21 02:16:36, commit-bot: I haz the power wrote: > Committed patchset #2 (id:80001) Manually (because of the size of histograms.xm) reverted in https://codereview.chromium.org/2437283003
Message was sent while issue was closed.
Description was changed from ========== Add histograms that monitor variation seed fetching from Java. Depends on https://codereview.chromium.org/2435813002/ which is moving the implementation of CachedMetrics to base from chrome/. BUG=632199 ========== to ========== Add histograms that monitor variation seed fetching from Java. Depends on https://codereview.chromium.org/2435813002/ which is moving the implementation of CachedMetrics to base from chrome/. BUG=632199 Committed: https://crrev.com/6c139a2b0943224d42b1402584ab3c21d28d5232 Cr-Commit-Position: refs/heads/master@{#426689} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6c139a2b0943224d42b1402584ab3c21d28d5232 Cr-Commit-Position: refs/heads/master@{#426689}
Message was sent while issue was closed.
Relanding via: https://codereview.chromium.org/2442823002/ |