Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2426343004: Add histograms that monitor variation seed fetching from Java. (Closed)

Created:
4 years, 2 months ago by Alexei Svitkine (slow)
Modified:
4 years, 2 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histograms that monitor variation seed fetching from Java. Depends on https://codereview.chromium.org/2435813002/ which is moving the implementation of CachedMetrics to base from chrome/. BUG=632199 Committed: https://crrev.com/6c139a2b0943224d42b1402584ab3c21d28d5232 Cr-Commit-Position: refs/heads/master@{#426689}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -6 lines) Patch
M components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedService.java View 5 chunks +36 lines, -6 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +62 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (19 generated)
Alexei Svitkine (slow)
4 years, 2 months ago (2016-10-20 17:06:54 UTC) #16
rkaplow
lgtm https://codereview.chromium.org/2426343004/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2426343004/diff/60001/tools/metrics/histograms/histograms.xml#newcode67680 tools/metrics/histograms/histograms.xml:67680: + The latency of a fetching an initial ...
4 years, 2 months ago (2016-10-20 17:32:55 UTC) #17
Alexei Svitkine (slow)
https://codereview.chromium.org/2426343004/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2426343004/diff/60001/tools/metrics/histograms/histograms.xml#newcode67680 tools/metrics/histograms/histograms.xml:67680: + The latency of a fetching an initial variations ...
4 years, 2 months ago (2016-10-20 17:35:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426343004/80001
4 years, 2 months ago (2016-10-21 00:09:42 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:80001)
4 years, 2 months ago (2016-10-21 02:16:36 UTC) #23
Dmitry Skiba
On 2016/10/21 02:16:36, commit-bot: I haz the power wrote: > Committed patchset #2 (id:80001) Manually ...
4 years, 2 months ago (2016-10-21 03:27:13 UTC) #24
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6c139a2b0943224d42b1402584ab3c21d28d5232 Cr-Commit-Position: refs/heads/master@{#426689}
4 years, 2 months ago (2016-10-21 13:26:07 UTC) #26
Alexei Svitkine (slow)
4 years, 2 months ago (2016-10-21 20:17:43 UTC) #27
Message was sent while issue was closed.
Relanding via: https://codereview.chromium.org/2442823002/

Powered by Google App Engine
This is Rietveld 408576698