Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2435813002: Move Java CachedMetrics functionality to base/. (Closed)

Created:
4 years, 2 months ago by Alexei Svitkine (slow)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, zpeng+watch_chromium.org, dominickn+watch_chromium.org, skanuj+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, lizeb+watch-custom-tabs_chromium.org, David Black, asvitkine+watch_chromium.org, agrieve+watch_chromium.org, kmadhusu+watch_chromium.org, jfweitz+watch_chromium.org, pkotwicz+watch_chromium.org, Jered, nyquist
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Java CachedMetrics functionality to base/. This is general-purpose functionality that allows recording UMA metrics before the C++ native library has been loaded and is useful to have outside of the Chrome layer. In particular, I will be using it from components/variations to record information about the first run variations seed fetch. No functional changes in this CL. BUG=632199 Committed: https://crrev.com/b7e5cadf6d33f5ff1a307f30e1ff18876c3760eb Cr-Commit-Position: refs/heads/master@{#426652}

Patch Set 1 #

Patch Set 2 : Fix compile. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -252 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A + base/android/java/src/org/chromium/base/metrics/CachedMetrics.java View 2 chunks +9 lines, -87 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabBottomBarDelegate.java View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/UserRecoverableErrorHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/instantapps/InstantAppsHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/metrics/LaunchMetrics.java View 3 chunks +2 lines, -149 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/metrics/MediaNotificationUma.java View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappAuthenticator.java View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 29 (17 generated)
Alexei Svitkine (slow)
4 years, 2 months ago (2016-10-19 19:21:04 UTC) #9
Alexei Svitkine (slow)
bauerb: overall review nyquist: base/android OWNERS review Thanks!
4 years, 2 months ago (2016-10-19 19:24:15 UTC) #13
Alexei Svitkine (slow)
Seems all of base/android OWNERS are OOO this week. So I might have to switch ...
4 years, 2 months ago (2016-10-19 20:16:11 UTC) #14
Bernhard Bauer
Nice! LGTM
4 years, 2 months ago (2016-10-20 12:45:59 UTC) #17
Alexei Svitkine (slow)
+thestig for base/ OWNERS since everyone in base/android/OWNERS is OOO this week. This change has ...
4 years, 2 months ago (2016-10-20 15:15:56 UTC) #19
Lei Zhang
rs lgtm
4 years, 2 months ago (2016-10-20 21:10:54 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435813002/40001
4 years, 2 months ago (2016-10-20 21:12:09 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-20 23:48:50 UTC) #23
Dmitry Skiba
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/2443483003/ by dskiba@google.com. ...
4 years, 2 months ago (2016-10-21 02:16:05 UTC) #24
DmitrySkiba
A revert of this CL (patchset #2 id:40001) has been created in https://codereview.chromium.org/2442503005/ by dskiba@chromium.org. ...
4 years, 2 months ago (2016-10-21 02:28:33 UTC) #25
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/b7e5cadf6d33f5ff1a307f30e1ff18876c3760eb Cr-Commit-Position: refs/heads/master@{#426652}
4 years, 2 months ago (2016-10-21 13:24:43 UTC) #27
Alexei Svitkine (slow)
4 years, 2 months ago (2016-10-21 20:14:07 UTC) #29
Message was sent while issue was closed.
Relanded as https://codereview.chromium.org/2439113002/

Powered by Google App Engine
This is Rietveld 408576698