Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 2437283003: Revert "Add histograms that monitor variation seed fetching from Java." (Closed)

Created:
4 years, 2 months ago by Dmitry Skiba
Modified:
4 years, 2 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add histograms that monitor variation seed fetching from Java." Reason for revert: Parent CL (https://crrev.com/2435813002) was reverted because it broke Clank. Original issue's description: > Add histograms that monitor variation seed fetching from Java. > > Depends on https://codereview.chromium.org/2435813002/ which > is moving the implementation of CachedMetrics to base from chrome/. > > BUG=632199 TBR=rkaplow@chromium.org,thestig@chromium.org,asvitkine@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=632199 Committed: https://crrev.com/673eae7b31642009320b256a0d3c388823134b0d Cr-Commit-Position: refs/heads/master@{#426709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -98 lines) Patch
M components/variations/android/java/src/org/chromium/components/variations/firstrun/VariationsSeedService.java View 5 chunks +6 lines, -36 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +0 lines, -62 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Ted C
lgtm
4 years, 2 months ago (2016-10-21 03:30:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2437283003/1
4 years, 2 months ago (2016-10-21 03:31:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-21 03:34:29 UTC) #5
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:26:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/673eae7b31642009320b256a0d3c388823134b0d
Cr-Commit-Position: refs/heads/master@{#426709}

Powered by Google App Engine
This is Rietveld 408576698