Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2426083002: Clean up other instances where Tab WindowAndroid was being set to null. (Closed)

Created:
4 years, 2 months ago by mthiesse
Modified:
4 years, 1 month ago
Reviewers:
Ted C, Yusuf
CC:
chromium-reviews, jam, darin-cc_chromium.org, agrieve+watch_chromium.org, Yusuf
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up other instances where Tab WindowAndroid was being set to null. BUG=657007 Committed: https://crrev.com/410dd90a44cc3a0a7d805122df31f7e65f377aa7 Cr-Commit-Position: refs/heads/master@{#429048}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -11 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 1 2 chunks +0 lines, -3 lines 0 comments Download
M content/browser/android/content_view_core_impl.cc View 1 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
mthiesse
PTAL
4 years, 2 months ago (2016-10-18 17:24:04 UTC) #3
Ted C
I'll let yusufo@ take a first look and owners approve it afterwards.
4 years, 2 months ago (2016-10-18 17:31:32 UTC) #5
Yusuf
lgtm
4 years, 2 months ago (2016-10-19 18:05:43 UTC) #6
mthiesse
Friendly ping, PTAL Ted.
4 years, 1 month ago (2016-11-01 14:26:41 UTC) #7
Ted C
lgtm
4 years, 1 month ago (2016-11-01 17:10:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426083002/1
4 years, 1 month ago (2016-11-01 17:13:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/326528)
4 years, 1 month ago (2016-11-01 17:16:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2426083002/20001
4 years, 1 month ago (2016-11-01 17:30:04 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-01 18:04:04 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 18:24:51 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/410dd90a44cc3a0a7d805122df31f7e65f377aa7
Cr-Commit-Position: refs/heads/master@{#429048}

Powered by Google App Engine
This is Rietveld 408576698