Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1242)

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2426083002: Clean up other instances where Tab WindowAndroid was being set to null. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index fe87f989dc03c54b6bf24e5994628086a83853fd..ffa57addb6c49bf19cd07757f36828e563dc91a0 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -267,18 +267,20 @@ void ContentViewCoreImpl::UpdateWindowAndroid(
const base::android::JavaParamRef<jobject>& obj,
jlong window_android) {
ui::ViewAndroid* view = GetViewAndroid();
- if (window_android) {
- DCHECK(!GetWindowAndroid());
- ui::WindowAndroid* window =
- reinterpret_cast<ui::WindowAndroid*>(window_android);
- window->AddChild(view);
- for (auto& observer : observer_list_)
- observer.OnAttachedToWindow();
- } else {
+ ui::WindowAndroid* window =
+ reinterpret_cast<ui::WindowAndroid*>(window_android);
+ if (window == GetWindowAndroid())
+ return;
+ if (GetWindowAndroid()) {
for (auto& observer : observer_list_)
observer.OnDetachedFromWindow();
view->RemoveFromParent();
}
+ if (window) {
+ window->AddChild(view);
+ for (auto& observer : observer_list_)
+ observer.OnAttachedToWindow();
+ }
}
base::android::ScopedJavaLocalRef<jobject>
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698