Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 2426083002: Clean up other instances where Tab WindowAndroid was being set to null. (Closed)
Patch Set: Rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 221c50c7202d2ebb3556a088f60927255d5d3bfb..76d32aa1a716c9d8a4315c6c86522d9f17e584b0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -1618,6 +1618,8 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
* @param windowAndroid The WindowAndroid to propagate.
*/
public void updateWindowAndroid(WindowAndroid windowAndroid) {
+ // TODO(yusufo): mWindowAndroid can never be null until crbug.com/657007 is fixed.
+ assert windowAndroid != null;
mWindowAndroid = windowAndroid;
if (mContentViewCore != null) mContentViewCore.updateWindowAndroid(mWindowAndroid);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698