cc/surfaces/surface_id_allocator.cc - Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/surfaces/surface_id_allocator.cc

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)

Patch Set: Removed added printf statements; LocalFrameId::is_valid() no longer checks if nonce is 0. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/surfaces/surface_id_allocator.cc

diff --git a/cc/surfaces/surface_id_allocator.cc b/cc/surfaces/surface_id_allocator.cc

index af4d5932df723a6da76dc79377e0430248785966..e6c4194444275407b3306634111785aa3ce1ce81 100644

--- a/cc/surfaces/surface_id_allocator.cc

+++ b/cc/surfaces/surface_id_allocator.cc

@@ -17,6 +17,10 @@ SurfaceIdAllocator::~SurfaceIdAllocator() {

LocalFrameId SurfaceIdAllocator::GenerateId() {

uint64_t nonce = base::RandUint64();

+ // Since 0 nonce are treated as uninitialized and thus invalid, we need to

+ // keep generating until there is a non-zero nonce

+ while (nonce == 0)

+ nonce = base::RandUint64();

LocalFrameId id(next_id_, nonce);

next_id_++;

return id;