cc/surfaces/surface_id.h - Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/surfaces/surface_id.h

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)

Patch Set: Removed added printf statements; LocalFrameId::is_valid() no longer checks if nonce is 0. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/surfaces/surface_id.h

diff --git a/cc/surfaces/surface_id.h b/cc/surfaces/surface_id.h

index 5be370ed3fb427249f2ec9b6428bb37984eedbce..8333971ddb344715d71cdc32b98655f2ed8a0cbd 100644

--- a/cc/surfaces/surface_id.h

+++ b/cc/surfaces/surface_id.h

@@ -41,6 +41,10 @@ class SurfaceId {

const LocalFrameId& local_frame_id)

: frame_sink_id_(frame_sink_id), local_frame_id_(local_frame_id) {}

+ bool is_valid() const {

+ return frame_sink_id_.is_valid() && local_frame_id_.is_valid();

+ }

bool is_null() const {

return frame_sink_id_.is_null() && local_frame_id_.is_null();

}