Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/surfaces/surface_sequence.h

Issue 2425923003: Replaced is_null() with is_valid in SurfaceId and related classes. (Closed)
Patch Set: Removed added printf statements; LocalFrameId::is_valid() no longer checks if nonce is 0. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« cc/surfaces/local_frame_id.h ('K') | « cc/surfaces/surface_id_allocator.cc ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_sequence.h
diff --git a/cc/surfaces/surface_sequence.h b/cc/surfaces/surface_sequence.h
index f847d0b53386764b8616a2fd0321078b70d17336..3ea67e48609c32efb9d02b41ecae10efe4d4a6d6 100644
--- a/cc/surfaces/surface_sequence.h
+++ b/cc/surfaces/surface_sequence.h
@@ -21,8 +21,10 @@ namespace cc {
struct SurfaceSequence {
SurfaceSequence() : sequence(0u) {}
SurfaceSequence(const FrameSinkId& frame_sink_id, uint32_t sequence)
- : frame_sink_id(frame_sink_id), sequence(sequence) {}
- bool is_null() const { return frame_sink_id.is_null() && sequence == 0u; }
+ : frame_sink_id(frame_sink_id), sequence(sequence) {
+ DCHECK(frame_sink_id.is_valid());
+ }
+ bool is_valid() const { return frame_sink_id.is_valid() && sequence > 0u; }
FrameSinkId frame_sink_id;
uint32_t sequence;
« cc/surfaces/local_frame_id.h ('K') | « cc/surfaces/surface_id_allocator.cc ('k') | cc/test/test_compositor_frame_sink.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698