Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2425703002: Remove |remote| and |readonly| members of MediaStreamTrack (Closed)

Created:
4 years, 2 months ago by Yeol Park
Modified:
3 years, 9 months ago
CC:
avayvod+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, einbinder+watch-test-runner_chromium.org, eric.carlson_apple.com, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, haraken, hongchan, imcheng+watch_chromium.org, isheriff+watch_chromium.org, jam, jasonroberts+watch_google.com, jochen+watch_chromium.org, mcasas+watch+vc_chromium.org, mcasas+watch+mediastream_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, mlamouri+watch-blink_chromium.org, Peter Beverloo, posciak+watch_chromium.org, Raymond Toy, Srirama, tommyw+watchlist_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove |remote| and |readonly| members of MediaStreamTrack. Spec reference: http://w3c.github.io/mediacapture-main/getusermedia.html#attributes-1 removal was in the February 22, 2016'. [#321] Remove track attributes "remote" and "readonly" : https://github.com/w3c/mediacapture-main/pull/321 Intent to Deprecate and Remove : https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/d20ECb2sWzI BUG=598704 Review-Url: https://codereview.chromium.org/2425703002 Cr-Commit-Position: refs/heads/master@{#452851} Committed: https://chromium.googlesource.com/chromium/src/+/a72385a6addeb6194d3568beda3f352e07c97260

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove |remote| and |readonly| members of MediaStreamTrack #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : fix build error for unittests #

Patch Set 5 : fix build error #

Patch Set 6 : rebase #

Patch Set 7 : fix build error #

Patch Set 8 : modified blink_tests #

Patch Set 9 : rebase #

Patch Set 10 : Remove |remote| and |readonly| members of MediaStreamTrack. #

Patch Set 11 : Fixed webkit_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -263 lines) Patch
M chrome/renderer/extensions/cast_streaming_native_handler.cc View 1 2 1 chunk +2 lines, -6 lines 0 comments Download
M content/public/renderer/media_stream_utils.h View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/renderer/media_stream_utils.cc View 1 2 4 chunks +5 lines, -12 lines 0 comments Download
M content/renderer/media/capturefromelement/canvas_capture_handler.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/capturefromelement/html_audio_element_capturer_source_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/external_media_stream_audio_source.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/external_media_stream_audio_source.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_audio_source.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/media_stream_audio_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_capturer_source_unittest.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_video_renderer_sink_unittest.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_source_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_track_unittest.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/media/mock_media_stream_registry.cc View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M content/renderer/media/pepper_to_video_track_adapter.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/remote_media_stream_impl.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/rtc_peer_connection_handler_unittest.cc View 1 2 3 4 5 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/media/speech_recognition_audio_sink_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms_compositor.cc View 1 2 3 4 5 2 chunks +2 lines, -6 lines 0 comments Download
M content/renderer/media/webrtc/media_stream_remote_video_source_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/webrtc/processed_local_audio_source_unittest.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/webrtc/webrtc_media_stream_adapter_unittest.cc View 1 2 3 chunks +5 lines, -11 lines 0 comments Download
M content/renderer/media/webrtc_local_audio_source_provider_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media_recorder/audio_track_recorder_unittest.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 2 3 4 5 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -6 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 2 3 4 5 6 7 8 2 chunks +0 lines, -4 lines 0 comments Download
M content/shell/test_runner/mock_web_user_media_client.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/test_runner/mock_webrtc_peer_connection_handler.cc View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/MediaStreamTrack-init.https-expected.txt View 1 2 3 4 5 6 7 8 9 10 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams.html View 1 2 3 4 5 6 7 1 chunk +0 lines, -86 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-remotestreams-expected.txt View 1 2 3 4 5 6 7 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 10 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.idl View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp View 1 2 2 chunks +1 line, -14 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h View 1 2 3 4 5 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp View 1 2 3 4 5 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/public/platform/WebMediaStreamSource.h View 1 2 3 4 5 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 92 (63 generated)
Yeol Park
PTAL :) aboxhall@ for chrome/renderer/extensions/cast_streaming_native_handler.cc scottmg@ for content/public/renderer/* mcasas@ for content/renderer/media/* bbudge@ for content/renderer/pepper/pepper_media_stream_video_track_host.cc esprehn@ ...
4 years, 2 months ago (2016-10-17 13:52:01 UTC) #3
Yeol Park
PTAL :) aboxhall@ for chrome/renderer/extensions/cast_streaming_native_handler.cc scottmg@ for content/public/renderer/* mcasas@ for content/renderer/media/* bbudge@ for content/renderer/pepper/pepper_media_stream_video_track_host.cc esprehn@ ...
4 years, 2 months ago (2016-10-17 13:53:09 UTC) #4
drott
> drott@ for third_party/WebKit/Source/platform/* third_party/WebKit/Source/platform/* LGTM
4 years, 2 months ago (2016-10-17 14:22:54 UTC) #5
jochen (gone - plz use gerrit)
can you please link to the intent to remove thread in the CL description
4 years, 2 months ago (2016-10-17 14:23:43 UTC) #7
bbudge
content/renderer/pepper lgtm
4 years, 2 months ago (2016-10-17 17:38:33 UTC) #8
mcasas
lgtm content/renderer/media with a few comments and assuming bots are happy. https://codereview.chromium.org/2425703002/diff/1/content/renderer/media/external_media_stream_audio_source.cc File content/renderer/media/external_media_stream_audio_source.cc (right): ...
4 years, 2 months ago (2016-10-17 18:08:25 UTC) #9
hta - Chromium
The usage isn't huge (low enough to just bounce up and down on https://www.chromestatus.com/metrics/feature/timeline/popularity/1306) - ...
4 years, 2 months ago (2016-10-17 18:28:37 UTC) #10
hta - Chromium
Note: The |readonly| member was removed some time ago. Please update the title and description ...
4 years, 2 months ago (2016-10-17 18:34:19 UTC) #11
Peter Beverloo
//content/shell and //third_party/WebKit/Source/modules/mediastream/ lgtm This property saw such incredible minor usage over the past seven ...
4 years, 2 months ago (2016-10-18 15:50:43 UTC) #12
hongchan
WebAudio lgtm (Source/modules/webaudio/MediaStreamAudioDestinationNode.cpp)
4 years, 2 months ago (2016-10-18 15:55:59 UTC) #13
Yeol Park
On 2016/10/17 18:34:19, hta - Chromium wrote: > Note: The |readonly| member was removed some ...
4 years, 2 months ago (2016-10-19 07:28:29 UTC) #14
Yeol Park
On 2016/10/17 14:23:43, jochen wrote: > can you please link to the intent to remove ...
4 years, 2 months ago (2016-10-19 08:51:03 UTC) #18
jochen (gone - plz use gerrit)
On 2016/10/19 at 08:51:03, peary2 wrote: > On 2016/10/17 14:23:43, jochen wrote: > > can ...
4 years, 2 months ago (2016-10-19 09:14:00 UTC) #19
aboxhall
On 2016/10/17 13:52:01, Park Yeol wrote: > PTAL :) > > aboxhall@ for chrome/renderer/extensions/cast_streaming_native_handler.cc > ...
4 years, 2 months ago (2016-10-19 21:33:51 UTC) #20
miu
lgtm % a couple concerns. BTW--When you go to remove the is_local_source_ from content/renderer/media/media_stream_audio_source.h, which ...
4 years, 2 months ago (2016-10-23 00:51:30 UTC) #22
esprehn
third_party/Webkit lgtm
4 years, 1 month ago (2016-10-25 00:05:37 UTC) #23
hta - Chromium
lgtm Note that my previous comments on the subject line and CL description have not ...
4 years ago (2016-12-14 09:51:12 UTC) #24
Yeol Park
On 2016/12/14 09:51:12, hta - Chromium wrote: > lgtm > > Note that my previous ...
3 years, 11 months ago (2017-01-20 04:04:25 UTC) #28
jochen (gone - plz use gerrit)
thank you. I'll approve this CL once the intent has its required three approvals!
3 years, 11 months ago (2017-01-20 07:31:21 UTC) #29
Yeol Park
I was rebase in Patch set 4 for latest source. Could you run CQ bot? ...
3 years, 11 months ago (2017-01-25 09:10:48 UTC) #30
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-25 12:24:16 UTC) #31
Yeol Park
I was rebase in Patch set 4 for unittests Could you run CQ bot? :)
3 years, 11 months ago (2017-01-26 06:04:29 UTC) #36
hta - Chromium
On 2017/01/26 06:04:29, Park Yeol wrote: > I was rebase in Patch set 4 for ...
3 years, 11 months ago (2017-01-26 09:45:24 UTC) #41
miu
Park: Friendly reminder, please check on my comments from #22 before committing.
3 years, 10 months ago (2017-01-30 21:54:35 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425703002/120001
3 years, 10 months ago (2017-02-07 11:47:25 UTC) #46
Yeol Park
PTAL :) miu@ for your comment #22 ../content/renderer/media/external_media_stream_audio_source.cc ../content/renderer/media/webmediaplayer_ms_compositor.cc Thank you for your information. On ...
3 years, 10 months ago (2017-02-07 11:56:01 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425703002/200001
3 years, 10 months ago (2017-02-24 16:48:07 UTC) #88
commit-bot: I haz the power
Committed patchset #10 (id:200001) as https://chromium.googlesource.com/chromium/src/+/a72385a6addeb6194d3568beda3f352e07c97260
3 years, 10 months ago (2017-02-24 16:53:49 UTC) #91
Mathieu
3 years, 10 months ago (2017-02-24 17:44:06 UTC) #92
Message was sent while issue was closed.
A revert of this CL (patchset #10 id:200001) has been created in
https://codereview.chromium.org/2710213005/ by mathp@chromium.org.

The reason for reverting is: Failure on webkit_tests:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty...

external/wpt/mediacapture-streams/MediaStreamTrack-init.https.html.

Powered by Google App Engine
This is Rietveld 408576698