[Sync] Moved down comments directly following copyright.

[Sync] Moved down comments directly following copyright.

BUG=656780
Committed: https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651
Cr-Commit-Position: refs/heads/master@{#425971}

[skym, 2016-10-17 20:17:04]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 20:17:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[skym, 2016-10-17 20:18:46]

skym@chromium.org changed reviewers:
+ maxbogue@chromium.org

[skym, 2016-10-17 20:18:47]

PTAL

[commit-bot: I haz the power, 2016-10-17 21:56:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 21:56:22]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-10-17 23:59:47]

lgtm with a few comments

https://codereview.chromium.org/2425673003/diff/20001/components/sync/base/mo...
File components/sync/base/model_type.h (right):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/base/mo...
components/sync/base/model_type.h:33: 
Since this is one continuous comment block that has paragraphs, this line and
line 36 should have //.

https://codereview.chromium.org/2425673003/diff/20001/components/sync/base/pr...
File components/sync/base/pref_names.h (right):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/base/pr...
components/sync/base/pref_names.h:14: // Constants for the names of various sync
preferences, for easier changing.
This comment is ironic since changing a preference value isn't really something
we can do (you lose the old value, right?). But it's fine to leave it.

Also this could probably just live right above the namespace prefs { line? But
either way.

https://codereview.chromium.org/2425673003/diff/20001/components/sync/engine_...
File components/sync/engine_impl/all_status.h (right):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/engine_...
components/sync/engine_impl/all_status.h:26: // This class watches various sync
engine components, udaping its internal state
updating*

https://codereview.chromium.org/2425673003/diff/20001/components/sync/engine_...
File components/sync/engine_impl/conflict_util.h (right):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/engine_...
components/sync/engine_impl/conflict_util.h:16: // Utility functions that act on
syncable::MutableEntry to resolve conflicts.
Could probably put this right above the namespace? Almost like a class comment
but for a namespace of static functions? I do not feel strongly at all about
this though.

https://codereview.chromium.org/2425673003/diff/20001/components/sync/model/t...
File components/sync/model/time.h (right):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/model/t...
components/sync/model/time.h:11: // See sync/util/time.h for implemenation.
components/sync/base/time.h* implementation*

https://codereview.chromium.org/2425673003/diff/20001/components/sync/protoco...
File components/sync/protocol/proto_enum_conversions.cc (left):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/protoco...
components/sync/protocol/proto_enum_conversions.cc:5: // Keep this file in sync
with the .proto files in this directory.
Didn't want to leave this one in somewhere?

https://codereview.chromium.org/2425673003/diff/20001/components/sync/protoco...
File components/sync/protocol/proto_value_conversions.cc (left):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/protoco...
components/sync/protocol/proto_value_conversions.cc:5: // Keep this file in sync
with the .proto files in this directory.
Didn't want to keep this one somewhere?

[skym, 2016-10-18 14:39:08]

https://codereview.chromium.org/2425673003/diff/20001/components/sync/base/mo...
File components/sync/base/model_type.h (right):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/base/mo...
components/sync/base/model_type.h:33: 
On 2016/10/17 23:59:46, maxbogue wrote:
> Since this is one continuous comment block that has paragraphs, this line and
> line 36 should have //.

Done.

https://codereview.chromium.org/2425673003/diff/20001/components/sync/base/pr...
File components/sync/base/pref_names.h (right):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/base/pr...
components/sync/base/pref_names.h:14: // Constants for the names of various sync
preferences, for easier changing.
On 2016/10/17 23:59:46, maxbogue wrote:
> This comment is ironic since changing a preference value isn't really
something
> we can do (you lose the old value, right?). But it's fine to leave it.
> 
> Also this could probably just live right above the namespace prefs { line? But
> either way.

Haha, you make a great point about them not really being change-able. I'm just
going to remove this comment, it's not really adding value.

https://codereview.chromium.org/2425673003/diff/20001/components/sync/engine_...
File components/sync/engine_impl/all_status.h (right):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/engine_...
components/sync/engine_impl/all_status.h:26: // This class watches various sync
engine components, udaping its internal state
On 2016/10/17 23:59:46, maxbogue wrote:
> updating*

Done.

https://codereview.chromium.org/2425673003/diff/20001/components/sync/engine_...
File components/sync/engine_impl/conflict_util.h (right):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/engine_...
components/sync/engine_impl/conflict_util.h:16: // Utility functions that act on
syncable::MutableEntry to resolve conflicts.
On 2016/10/17 23:59:46, maxbogue wrote:
> Could probably put this right above the namespace? Almost like a class comment
> but for a namespace of static functions? I do not feel strongly at all about
> this though.

Done.

https://codereview.chromium.org/2425673003/diff/20001/components/sync/model/t...
File components/sync/model/time.h (right):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/model/t...
components/sync/model/time.h:11: // See sync/util/time.h for implemenation.
On 2016/10/17 23:59:46, maxbogue wrote:
> components/sync/base/time.h* implementation*

Done.

https://codereview.chromium.org/2425673003/diff/20001/components/sync/protoco...
File components/sync/protocol/proto_enum_conversions.cc (left):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/protoco...
components/sync/protocol/proto_enum_conversions.cc:5: // Keep this file in sync
with the .proto files in this directory.
On 2016/10/17 23:59:46, maxbogue wrote:
> Didn't want to leave this one in somewhere?

I felt like these .cc files don't really need this message. The .h and
unittest.cc already have this, and the .cc will have to update to keep the .h
and unittest.cc working. So I removed.

https://codereview.chromium.org/2425673003/diff/20001/components/sync/protoco...
File components/sync/protocol/proto_value_conversions.cc (left):

https://codereview.chromium.org/2425673003/diff/20001/components/sync/protoco...
components/sync/protocol/proto_value_conversions.cc:5: // Keep this file in sync
with the .proto files in this directory.
On 2016/10/17 23:59:47, maxbogue wrote:
> Didn't want to keep this one somewhere?

Acknowledged.

[skym, 2016-10-18 14:39:13]

The CQ bit was checked by skym@chromium.org

[skym, 2016-10-18 14:39:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2425673003/#ps40001
(title: "Updates for Max.")

[commit-bot: I haz the power, 2016-10-18 14:39:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 15:40:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-18 15:43:20]

Description was changed from

==========
[Sync] Moved down comments directly following copyright.

BUG=656780
==========

to

==========
[Sync] Moved down comments directly following copyright.

BUG=656780

Committed: https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651
Cr-Commit-Position: refs/heads/master@{#425971}
==========

[commit-bot: I haz the power, 2016-10-18 15:43:21]

Patchset 3 (id:??) landed as
https://crrev.com/d5e266155ae8b19552f638d85ef12b04dfaec651
Cr-Commit-Position: refs/heads/master@{#425971}