components/sync/protocol/proto_enum_conversions.cc - Issue 2425673003: [Sync] Moved down comments directly following copyright.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/sync/protocol/proto_enum_conversions.cc

Issue 2425673003: [Sync] Moved down comments directly following copyright. (Closed)

Patch Set: Rebase and removing TODO about exporting. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/sync/model/time.h ('K') | « components/sync/protocol/proto_enum_conversions.h ('k') | components/sync/protocol/proto_enum_conversions_unittest.cc » ('j') | components/sync/protocol/proto_value_conversions.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Keep this file in sync with the .proto files in this directory.
maxbogue 2016/10/17 23:59:46 Didn't want to leave this one in somewhere? Didn't want to leave this one in somewhere? skym 2016/10/18 14:39:08 I felt like these .cc files don't really need this Show quoted text On 2016/10/17 23:59:46, maxbogue wrote: > Didn't want to leave this one in somewhere? I felt like these .cc files don't really need this message. The .h and unittest.cc already have this, and the .cc will have to update to keep the .h and unittest.cc working. So I removed.
6

7 #include "components/sync/protocol/proto_enum_conversions.h"	5 #include "components/sync/protocol/proto_enum_conversions.h"

8	6

9 #include "base/logging.h"	7 #include "base/logging.h"

10	8

11 namespace syncer {	9 namespace syncer {

12	10

13 #define ASSERT_ENUM_BOUNDS(enum_parent, enum_type, enum_min, enum_max) \	11 #define ASSERT_ENUM_BOUNDS(enum_parent, enum_type, enum_min, enum_max) \

14 static_assert(enum_parent::enum_type##_MIN == enum_parent::enum_min, \	12 static_assert(enum_parent::enum_type##_MIN == enum_parent::enum_min, \

15 #enum_type "_MIN should be " #enum_min); \	13 #enum_type "_MIN should be " #enum_min); \

16 static_assert(enum_parent::enum_type##_MAX == enum_parent::enum_max, \	14 static_assert(enum_parent::enum_type##_MAX == enum_parent::enum_max, \

(...skipping 329 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
346 ENUM_CASE(sync_pb::ReadingListSpecifics, READ);	344 ENUM_CASE(sync_pb::ReadingListSpecifics, READ);

347 }	345 }

348 NOTREACHED();	346 NOTREACHED();

349 return "";	347 return "";

350 }	348 }

351	349

352 #undef ASSERT_ENUM_BOUNDS	350 #undef ASSERT_ENUM_BOUNDS

353 #undef ENUM_CASE	351 #undef ENUM_CASE

354	352

355 } // namespace syncer	353 } // namespace syncer

OLD	NEW