Ensure clean layout for VisibleSelection::selectionFromContentsOfNode

Ensure clean layout for VisibleSelection::selectionFromContentsOfNode

BUG=651373
Committed: https://crrev.com/401a4537d2469ceeb8a347f0b47d50f216fc2a03
Cr-Commit-Position: refs/heads/master@{#425646}

[Xiaocheng, 2016-10-17 05:20:53]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 05:21:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-17 06:25:06]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[Xiaocheng, 2016-10-17 06:25:07]

PTAL.

We can close crbug.com/651373 after this patch lands.

[commit-bot: I haz the power, 2016-10-17 06:45:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 06:46:00]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-17 07:05:23]

lgtm

BTW, we should get move updateStyleAndLayoutIgnorePendingStylesheets() from
ReplacementFragment::insertFragmentForTestRendering() to caller.
It is confusing that it seems selectionFromContentsOfNode() in
ReplacementFragment::ReplacementFragment() called with dirty layout at glance.

BTW^2, we should get rid of selectionFromContentsOfNode() by using
EphemeralRange::rangeOfContens() and SelectionTemplate::Builder

[tkent, 2016-10-17 07:08:16]

https://codereview.chromium.org/2425543003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleSelection.cpp (left):

https://codereview.chromium.org/2425543003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleSelection.cpp:251: //
TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
We should add a DCHECK and/or a comment to ensure clean layout.

[Xiaocheng, 2016-10-17 07:20:11]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 07:20:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-17 07:36:21]

Updated. Added TODOs for yosin's comment and DCHECKs for tkent's comment.

https://codereview.chromium.org/2425543003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleSelection.cpp (left):

https://codereview.chromium.org/2425543003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleSelection.cpp:251: //
TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
On 2016/10/17 at 07:08:16, tkent wrote:
> We should add a DCHECK and/or a comment to ensure clean layout.

Done.

[tkent, 2016-10-17 07:38:38]

lgtm

[commit-bot: I haz the power, 2016-10-17 10:06:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 10:06:57]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-17 10:07:43]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2016-10-17 10:07:43]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2425543003/#ps20001
(title: "201610171619")

[commit-bot: I haz the power, 2016-10-17 10:08:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 10:13:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-17 10:16:33]

Description was changed from

==========
Ensure clean layout for VisibleSelection::selectionFromContentsOfNode

BUG=651373
==========

to

==========
Ensure clean layout for VisibleSelection::selectionFromContentsOfNode

BUG=651373

Committed: https://crrev.com/401a4537d2469ceeb8a347f0b47d50f216fc2a03
Cr-Commit-Position: refs/heads/master@{#425646}
==========

[commit-bot: I haz the power, 2016-10-17 10:16:35]

Patchset 2 (id:??) landed as
https://crrev.com/401a4537d2469ceeb8a347f0b47d50f216fc2a03
Cr-Commit-Position: refs/heads/master@{#425646}