third_party/WebKit/Source/core/editing/VisibleSelection.h - Issue 2425543003: Ensure clean layout for VisibleSelection::selectionFromContentsOfNode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2425543003: Ensure clean layout for VisibleSelection::selectionFromContentsOfNode (Closed)

Patch Set: 201610171619 Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/VisibleSelection.h

diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h

index 195c3b945a6f1cfb34019055064a70d5d57267c6..9a8b29ebdb1a812f5d5a268c3fe488c04e83b16c 100644

--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h

+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h

@@ -63,6 +63,8 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {

// |selectionFromContentsOfNode|.

static VisibleSelectionTemplate create(const SelectionTemplate<Strategy>&);

+ // TODO(editing-dev): We should get rid of this function and instead, use

+ // EphemeralRangeTemplate::rangeOfContents and SelectionTemplate::Builder.

static VisibleSelectionTemplate selectionFromContentsOfNode(Node*);

SelectionType getSelectionType() const { return m_selectionType; }