Ensure clean layout for VisibleSelection::selectionFromContentsOfNode

third_party/WebKit/Source/core/editing/VisibleSelection.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 230 matching lines @@
   m_granularity = other.m_granularity;
   m_hasTrailingWhitespace = other.m_hasTrailingWhitespace;
   return *this;
 }
 
 template <typename Strategy>
 VisibleSelectionTemplate<Strategy>
 VisibleSelectionTemplate<Strategy>::selectionFromContentsOfNode(Node* node) {
   DCHECK(!Strategy::editingIgnoresContent(node));
 
-  // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets

[tkent, 2016/10/17 07:08:16]

We should add a DCHECK and/or a comment to ensure clean layout.

[Xiaocheng, 2016/10/17 07:36:21]

Done.

-  // needs to be audited. see http://crbug.com/590369 for more details.
-  node->document().updateStyleAndLayoutIgnorePendingStylesheets();
-
   typename SelectionTemplate<Strategy>::Builder builder;
   builder.collapse(PositionTemplate<Strategy>::firstPositionInNode(node))
       .extend(PositionTemplate<Strategy>::lastPositionInNode(node));
   return VisibleSelectionTemplate::create(builder.build());
 }
 
 template <typename Strategy>
 void VisibleSelectionTemplate<Strategy>::setBase(
     const PositionTemplate<Strategy>& position) {
   DCHECK(!needsLayoutTreeUpdate(position));
@@ skipping 711 matching lines @@
 
 void showTree(const blink::VisibleSelectionInFlatTree& sel) {
   sel.showTreeForThis();
 }
 
 void showTree(const blink::VisibleSelectionInFlatTree* sel) {
   if (sel)
     sel->showTreeForThis();
 }
 #endif