Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 24255015: Revert "Allow control intructions to have side effects." (Closed)

Created:
7 years, 3 months ago by oliv
Modified:
7 years, 3 months ago
Reviewers:
titzer
CC:
v8-dev
Visibility:
Public.

Description

Revert "Allow control intructions to have side effects." Breaks arm build. BUG= TBR=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16903

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -410 lines) Patch
M src/arm/lithium-arm.h View 3 chunks +5 lines, -6 lines 0 comments Download
M src/arm/lithium-arm.cc View 3 chunks +7 lines, -13 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M src/hydrogen-instructions.h View 7 chunks +17 lines, -84 lines 0 comments Download
M src/hydrogen-instructions.cc View 3 chunks +3 lines, -22 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +5 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 3 chunks +7 lines, -13 lines 0 comments Download
M src/utils.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M src/x64/lithium-x64.h View 3 chunks +5 lines, -6 lines 0 comments Download
M src/x64/lithium-x64.cc View 3 chunks +7 lines, -15 lines 0 comments Download
D test/mjsunit/compare-generic.js View 1 chunk +0 lines, -226 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
oliv
7 years, 3 months ago (2013-09-23 18:57:49 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r16903.

Powered by Google App Engine
This is Rietveld 408576698