Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 24255015: Revert "Allow control intructions to have side effects." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/utils.h ('k') | src/x64/lithium-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2586 matching lines...) Expand 10 before | Expand all | Expand 10 after
2597 2597
2598 2598
2599 void LCodeGen::DoInstanceSize(LInstanceSize* instr) { 2599 void LCodeGen::DoInstanceSize(LInstanceSize* instr) {
2600 Register object = ToRegister(instr->object()); 2600 Register object = ToRegister(instr->object());
2601 Register result = ToRegister(instr->result()); 2601 Register result = ToRegister(instr->result());
2602 __ movq(result, FieldOperand(object, HeapObject::kMapOffset)); 2602 __ movq(result, FieldOperand(object, HeapObject::kMapOffset));
2603 __ movzxbq(result, FieldOperand(result, Map::kInstanceSizeOffset)); 2603 __ movzxbq(result, FieldOperand(result, Map::kInstanceSizeOffset));
2604 } 2604 }
2605 2605
2606 2606
2607 void LCodeGen::DoCompareGenericAndBranch(LCompareGenericAndBranch* instr) { 2607 void LCodeGen::DoCmpT(LCmpT* instr) {
2608 Token::Value op = instr->op(); 2608 Token::Value op = instr->op();
2609 2609
2610 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op); 2610 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op);
2611 CallCode(ic, RelocInfo::CODE_TARGET, instr); 2611 CallCode(ic, RelocInfo::CODE_TARGET, instr);
2612 2612
2613 Condition condition = TokenToCondition(op, false); 2613 Condition condition = TokenToCondition(op, false);
2614 Label true_value, done; 2614 Label true_value, done;
2615 __ testq(rax, rax); 2615 __ testq(rax, rax);
2616 EmitBranch(instr, condition); 2616 __ j(condition, &true_value, Label::kNear);
2617 __ LoadRoot(ToRegister(instr->result()), Heap::kFalseValueRootIndex);
2618 __ jmp(&done, Label::kNear);
2619 __ bind(&true_value);
2620 __ LoadRoot(ToRegister(instr->result()), Heap::kTrueValueRootIndex);
2621 __ bind(&done);
2617 } 2622 }
2618 2623
2619 2624
2620 void LCodeGen::DoReturn(LReturn* instr) { 2625 void LCodeGen::DoReturn(LReturn* instr) {
2621 if (FLAG_trace && info()->IsOptimizing()) { 2626 if (FLAG_trace && info()->IsOptimizing()) {
2622 // Preserve the return value on the stack and rely on the runtime 2627 // Preserve the return value on the stack and rely on the runtime
2623 // call to return the value in the same register. 2628 // call to return the value in the same register.
2624 __ push(rax); 2629 __ push(rax);
2625 __ CallRuntime(Runtime::kTraceExit, 1); 2630 __ CallRuntime(Runtime::kTraceExit, 1);
2626 } 2631 }
(...skipping 2884 matching lines...) Expand 10 before | Expand all | Expand 10 after
5511 FixedArray::kHeaderSize - kPointerSize)); 5516 FixedArray::kHeaderSize - kPointerSize));
5512 __ bind(&done); 5517 __ bind(&done);
5513 } 5518 }
5514 5519
5515 5520
5516 #undef __ 5521 #undef __
5517 5522
5518 } } // namespace v8::internal 5523 } } // namespace v8::internal
5519 5524
5520 #endif // V8_TARGET_ARCH_X64 5525 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/utils.h ('k') | src/x64/lithium-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698