Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/arm/lithium-codegen-arm.cc

Issue 24255015: Revert "Allow control intructions to have side effects." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2870 matching lines...) Expand 10 before | Expand all | Expand 10 after
2881 2881
2882 2882
2883 void LCodeGen::DoInstanceSize(LInstanceSize* instr) { 2883 void LCodeGen::DoInstanceSize(LInstanceSize* instr) {
2884 Register object = ToRegister(instr->object()); 2884 Register object = ToRegister(instr->object());
2885 Register result = ToRegister(instr->result()); 2885 Register result = ToRegister(instr->result());
2886 __ ldr(result, FieldMemOperand(object, HeapObject::kMapOffset)); 2886 __ ldr(result, FieldMemOperand(object, HeapObject::kMapOffset));
2887 __ ldrb(result, FieldMemOperand(result, Map::kInstanceSizeOffset)); 2887 __ ldrb(result, FieldMemOperand(result, Map::kInstanceSizeOffset));
2888 } 2888 }
2889 2889
2890 2890
2891 void LCodeGen::DoCompareGenericAndBranch(LCompareGenericAndBranch* instr) { 2891 void LCodeGen::DoCmpT(LCmpT* instr) {
2892 Token::Value op = instr->op(); 2892 Token::Value op = instr->op();
2893 2893
2894 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op); 2894 Handle<Code> ic = CompareIC::GetUninitialized(isolate(), op);
2895 CallCode(ic, RelocInfo::CODE_TARGET, instr); 2895 CallCode(ic, RelocInfo::CODE_TARGET, instr);
2896 // This instruction also signals no smi code inlined. 2896 // This instruction also signals no smi code inlined.
2897 __ cmp(r0, Operand::Zero()); 2897 __ cmp(r0, Operand::Zero());
2898 2898
2899 Condition condition = ComputeCompareCondition(op); 2899 Condition condition = ComputeCompareCondition(op);
2900 EmitBranch(instr, condition); 2900 __ LoadRoot(ToRegister(instr->result()),
2901 Heap::kTrueValueRootIndex,
2902 condition);
2903 __ LoadRoot(ToRegister(instr->result()),
2904 Heap::kFalseValueRootIndex,
2905 NegateCondition(condition));
2901 } 2906 }
2902 2907
2903 2908
2904 void LCodeGen::DoReturn(LReturn* instr) { 2909 void LCodeGen::DoReturn(LReturn* instr) {
2905 if (FLAG_trace && info()->IsOptimizing()) { 2910 if (FLAG_trace && info()->IsOptimizing()) {
2906 // Push the return value on the stack as the parameter. 2911 // Push the return value on the stack as the parameter.
2907 // Runtime::TraceExit returns its parameter in r0. 2912 // Runtime::TraceExit returns its parameter in r0.
2908 __ push(r0); 2913 __ push(r0);
2909 __ CallRuntime(Runtime::kTraceExit, 1); 2914 __ CallRuntime(Runtime::kTraceExit, 1);
2910 } 2915 }
(...skipping 2871 matching lines...) Expand 10 before | Expand all | Expand 10 after
5782 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index)); 5787 __ sub(scratch, result, Operand::PointerOffsetFromSmiKey(index));
5783 __ ldr(result, FieldMemOperand(scratch, 5788 __ ldr(result, FieldMemOperand(scratch,
5784 FixedArray::kHeaderSize - kPointerSize)); 5789 FixedArray::kHeaderSize - kPointerSize));
5785 __ bind(&done); 5790 __ bind(&done);
5786 } 5791 }
5787 5792
5788 5793
5789 #undef __ 5794 #undef __
5790 5795
5791 } } // namespace v8::internal 5796 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698