Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2425453002: [Findit] Process analysis requests of Waterfall failures concurrently. (Closed)

Created:
4 years, 2 months ago by stgao
Modified:
4 years, 2 months ago
Reviewers:
chanli, lijeffrey
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Process analysis requests of Waterfall failures concurrently. This might not be the best fix, but it should work. Integration through Pub/Sub might be a better solution to decouple alerts-dispatcher and findit: no direct http requests from alerts-dispatcher to findit. BUG=655232 Committed: https://chromium.googlesource.com/infra/infra/+/545805bdd28931c2e13ca4e77ef623bf5e2df0aa

Patch Set 1 #

Patch Set 2 : fix nit. #

Total comments: 2

Patch Set 3 : fix nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -216 lines) Patch
M appengine/findit/common/constants.py View 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/findit/findit_api.py View 1 3 chunks +7 lines, -3 lines 0 comments Download
A + appengine/findit/handlers/process_failure_analysis_requests.py View 3 chunks +6 lines, -3 lines 0 comments Download
A + appengine/findit/handlers/test/process_failure_analysis_requests_test.py View 6 chunks +9 lines, -8 lines 0 comments Download
D appengine/findit/handlers/test/trigger_analyses_test.py View 1 chunk +0 lines, -144 lines 0 comments Download
D appengine/findit/handlers/trigger_analyses.py View 1 chunk +0 lines, -53 lines 0 comments Download
M appengine/findit/main.py View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M appengine/findit/queue.yaml View 2 chunks +9 lines, -0 lines 0 comments Download
M appengine/findit/waterfall-backend.yaml View 1 chunk +1 line, -1 line 0 comments Download
M appengine/findit/waterfall/build_failure_analysis_pipelines.py View 1 3 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
stgao
ptal
4 years, 2 months ago (2016-10-15 00:27:29 UTC) #3
chanli
On 2016/10/15 00:27:29, stgao wrote: > ptal lgtm with a nit
4 years, 2 months ago (2016-10-15 00:39:07 UTC) #4
chanli
https://codereview.chromium.org/2425453002/diff/20001/appengine/findit/main.py File appengine/findit/main.py (right): https://codereview.chromium.org/2425453002/diff/20001/appengine/findit/main.py#newcode22 appengine/findit/main.py:22: from handlers import process_failure_analysis_requests Nit: import order
4 years, 2 months ago (2016-10-15 00:39:47 UTC) #5
stgao
https://codereview.chromium.org/2425453002/diff/20001/appengine/findit/main.py File appengine/findit/main.py (right): https://codereview.chromium.org/2425453002/diff/20001/appengine/findit/main.py#newcode22 appengine/findit/main.py:22: from handlers import process_failure_analysis_requests On 2016/10/15 00:39:47, chanli wrote: ...
4 years, 2 months ago (2016-10-15 00:41:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425453002/40001
4 years, 2 months ago (2016-10-15 00:41:19 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/infra/infra/+/545805bdd28931c2e13ca4e77ef623bf5e2df0aa
4 years, 2 months ago (2016-10-15 00:55:58 UTC) #13
lijeffrey
4 years, 2 months ago (2016-10-15 01:25:18 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698