[Findit] Process analysis requests of Waterfall failures concurrently.

appengine/findit/waterfall/build_failure_analysis_pipelines.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from google.appengine.ext import ndb
 
 from common import appengine_util
 from common import constants
@@ skipping 24 matching lines @@
     analysis = WfAnalysis.Create(master_name, builder_name, build_number)
     analysis.status = analysis_status.PENDING
     analysis.request_time = time_util.GetUTCNow()
     analysis.put()
     return True
   elif force:
     # A new analysis could be forced if last analysis was completed.
     if not analysis.completed:
       # TODO: start a new analysis if the last one has started running but it
       # has no update for a considerable amount of time, eg. 10 minutes.
+      logging.info('Existing analysis is not completed yet. No new analysis.')
       return False
 
     analysis.Reset()
     analysis.request_time = time_util.GetUTCNow()
     analysis.put()
     return True
   elif failed_steps and analysis.completed:
     # If there is any new failed step, a new analysis is needed.
     for step in failed_steps:
       analyzed = any(step == s for s in analysis.not_passed_steps)
       if analyzed:
         continue
 
       logging.info('At least one new failed step is detected: %s', step)
       analysis.Reset()
       analysis.request_time = time_util.GetUTCNow()
       analysis.put()
       return True
 
   # Start a new analysis if the build cycle wasn't completed in last analysis,
   # but now it is completed. This will potentially trigger a try-job run.
   if analysis.completed and not analysis.build_completed and build_completed:
     return True
 
   # TODO: support following cases
   # * Automatically retry if last analysis failed with errors.
   # * Analysis is not complete and no update in the last 5 minutes.
+  logging.info('Not match any cases. No new analysis.')
   return False
 
 
 def ScheduleAnalysisIfNeeded(master_name, builder_name, build_number,
                              failed_steps=None,
                              build_completed=False,
                              force=False,
                              force_try_job=False,
                              queue_name=constants.DEFAULT_QUEUE):
   """Schedules an analysis if needed and returns the build analysis.
@@ skipping 29 matching lines @@
     # specified explicitly, and the default target is used rather than the one
     # in the queue.yaml file, but this contradicts the documentation in
     # https://cloud.google.com/appengine/docs/python/taskqueue/tasks#Task.
     pipeline_job.target = appengine_util.GetTargetNameForModule(
         constants.WATERFALL_BACKEND)
     pipeline_job.start(queue_name=queue_name)
 
     logging.info('An analysis was scheduled for build %s, %s, %s: %s',
                  master_name, builder_name, build_number,
                  pipeline_job.pipeline_status_path())
+  else:
+    logging.info('An analysis is not needed for build %s, %s, %s',
+                 master_name, builder_name, build_number)
 
   return WfAnalysis.Get(master_name, builder_name, build_number)