Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: appengine/findit/findit_api.py

Issue 2425453002: [Findit] Process analysis requests of Waterfall failures concurrently. (Closed)
Patch Set: fix nit. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/findit_api.py
diff --git a/appengine/findit/findit_api.py b/appengine/findit/findit_api.py
index f38411bbb9970bfbe9ab6eedcd509a4f80a9fb60..fb33498f31c99efbe7f7476f86af559b640deb1c 100644
--- a/appengine/findit/findit_api.py
+++ b/appengine/findit/findit_api.py
@@ -117,8 +117,9 @@ def _TriggerNewAnalysesOnDemand(builds):
target = appengine_util.GetTargetNameForModule(constants.WATERFALL_BACKEND)
payload = json.dumps({'builds': builds})
taskqueue.add(
- url=constants.WATERFALL_TRIGGER_ANALYSIS_URL, payload=payload,
- target=target, queue_name=constants.WATERFALL_SERIAL_QUEUE)
+ url=constants.WATERFALL_TRIGGER_ANALYSIS_URL,
+ payload=payload, target=target,
+ queue_name=constants.WATERFALL_FAILURE_ANALYSIS_REQUEST_QUEUE)
# Create a Cloud Endpoints API.
@@ -248,6 +249,8 @@ class FindItApi(remote.Service):
for build in request.builds:
master_name = buildbot.GetMasterNameFromUrl(build.master_url)
if not (master_name and waterfall_config.MasterIsSupported(master_name)):
+ logging.info('%s/%s/%s is not supported',
+ build.master_url, build.builder_name, build.build_number)
continue
supported_builds.append({
@@ -279,7 +282,8 @@ class FindItApi(remote.Service):
except Exception: # pragma: no cover.
# If we fail to post a task to the task queue, we ignore and wait for next
# request.
- logging.exception('Failed to trigger new analyses on demand.')
+ logging.exception('Failed to add analysis request to task queue: %s',
+ repr(supported_builds))
return _BuildFailureAnalysisResultCollection(results=results)
« no previous file with comments | « appengine/findit/common/constants.py ('k') | appengine/findit/handlers/process_failure_analysis_requests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698