Cleanup: Start using toFoo methods as part of newly adopted coding guideline.

Cleanup: Start using toFoo methods as part of newly adopted coding guideline.

As part of newly adopted coding guidelines, static_cast<Classname*> is discouraged and toFoo calling is encouraged. To enforce the new guideline, a patch (https://codereview.chromium.org/23654034/) on path to landing, which would raise presubmit error if it finds use of static_cast<Classname*> in the patch. This patch replaces static_cast<Classname*> in present codebase with toFoo(), at all places for which toFoo() is already defined.

R=tkent, inferno, abarth

BUG=None

TEST=None; no behavior change; No regressions with layout tests, webkit_unit_tests, content_unittests

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158094

[r.kasibhatla, 2013-09-19 14:00:53]

PTAL.

[inferno, 2013-09-19 14:25:59]

lgtm

[commit-bot: I haz the power, 2013-09-19 19:58:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/24253004/1

[commit-bot: I haz the power, 2013-09-19 19:59:12]

Failed to apply patch for Source/core/dom/Attr.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Attr.cpp
  Hunk #1 FAILED at 98.
  1 out of 1 hunk FAILED -- saving rejects to file Source/core/dom/Attr.cpp.rej

Patch:       Source/core/dom/Attr.cpp
Index: Source/core/dom/Attr.cpp
diff --git a/Source/core/dom/Attr.cpp b/Source/core/dom/Attr.cpp
index
0d20c05a43f440b6aed7bf8616e12d0708ca5563..8e722b9eb52c736a222c20d278964b0e748b53dd
100644
--- a/Source/core/dom/Attr.cpp
+++ b/Source/core/dom/Attr.cpp
@@ -98,7 +98,7 @@ void Attr::setPrefix(const AtomicString& prefix,
ExceptionState& es)
         return;
 
     if ((prefix == xmlnsAtom && namespaceURI() !=
XMLNSNames::xmlnsNamespaceURI)
-        || static_cast<Attr*>(this)->qualifiedName() == xmlnsAtom) {
+        || this->qualifiedName() == xmlnsAtom) {
         es.throwDOMException(NamespaceError);
         return;
     }

[r.kasibhatla, 2013-09-19 20:46:29]

Rebaselined to tot. Can anybody rubber stamp it.

[inferno, 2013-09-19 20:48:20]

lgtm

[commit-bot: I haz the power, 2013-09-19 20:48:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/24253004/5001

[r.kasibhatla, 2013-09-19 21:02:29]

Need lgtm from Source/web OWNERS - abarth/tkent?

[commit-bot: I haz the power, 2013-09-19 21:02:51]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[tkent, 2013-09-19 21:03:54]

lgtm

[commit-bot: I haz the power, 2013-09-19 21:04:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/24253004/5001

[commit-bot: I haz the power, 2013-09-19 21:48:53]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_layout.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[r.kasibhatla, 2013-09-20 07:15:09]

PTAL.
Just overlooked the earlier patch for Debug builds. Sorry about it. My bad. :(

[commit-bot: I haz the power, 2013-09-20 07:34:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/24253004/30001

[commit-bot: I haz the power, 2013-09-20 09:05:38]

Change committed as 158094