Source/web/tests/WebFrameTest.cpp - Issue 24253004: Cleanup: Start using toFoo methods as part of newly adopted coding guideline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/tests/WebFrameTest.cpp

Issue 24253004: Cleanup: Start using toFoo methods as part of newly adopted coding guideline. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/tests/WebFrameTest.cpp

diff --git a/Source/web/tests/WebFrameTest.cpp b/Source/web/tests/WebFrameTest.cpp

index 910d533efc0a4dd813315ada58a76807daa0d5be..41ff97db2763908f5fce07d29850c639035fdb70 100644

--- a/Source/web/tests/WebFrameTest.cpp

+++ b/Source/web/tests/WebFrameTest.cpp

@@ -885,7 +885,7 @@ TEST_F(WebFrameTest, WideViewportInitialScaleDoesNotExpandFixedLayoutWidth)

m_webView->settings()->setViewportMetaLayoutSizeQuirk(true);

m_webView->resize(WebSize(viewportWidth, viewportHeight));

- WebViewImpl* webViewImpl = static_cast<WebViewImpl*>(m_webView);

+ WebViewImpl* webViewImpl = toWebViewImpl(m_webView);

EXPECT_EQ(viewportWidth, webViewImpl->mainFrameImpl()->frameView()->fixedLayoutSize().width());

}

@@ -907,7 +907,7 @@ TEST_F(WebFrameTest, ZeroValuesQuirk)

Platform::current()->unitTestSupport()->serveAsynchronousMockedRequests();

m_webView->resize(WebSize(viewportWidth, viewportHeight));

- WebViewImpl* webViewImpl = static_cast<WebViewImpl*>(m_webView);

+ WebViewImpl* webViewImpl = toWebViewImpl(m_webView);

EXPECT_EQ(viewportWidth, webViewImpl->mainFrameImpl()->frameView()->fixedLayoutSize().width());

EXPECT_EQ(1.0f, m_webView->pageScaleFactor());

« no previous file with comments | « Source/web/tests/ScrollingCoordinatorChromiumTest.cpp ('k') | Source/web/tests/WebViewTest.cpp » ('j') | no next file with comments »