Source/core/dom/Position.cpp - Issue 24253004: Cleanup: Start using toFoo methods as part of newly adopted coding guideline.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Position.cpp

Issue 24253004: Cleanup: Start using toFoo methods as part of newly adopted coding guideline. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Position.cpp

diff --git a/Source/core/dom/Position.cpp b/Source/core/dom/Position.cpp

index 646f305ad25d3c970b53b39b399aa6bbaa69955d..8d52a1e59c15ea0bf34ca0181b834fa116332a62 100644

--- a/Source/core/dom/Position.cpp

+++ b/Source/core/dom/Position.cpp

@@ -674,7 +674,7 @@ Position Position::upstream(EditingBoundaryCrossingRule rule) const

otherBox = otherBox->nextLeafChild();

if (!otherBox)

break;

- if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && static_cast<InlineTextBox*>(otherBox)->start() > textOffset))

+ if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() > textOffset))

continuesOnNextLine = false;

}

@@ -683,7 +683,7 @@ Position Position::upstream(EditingBoundaryCrossingRule rule) const

otherBox = otherBox->prevLeafChild();

if (!otherBox)

break;

- if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && static_cast<InlineTextBox*>(otherBox)->start() > textOffset))

+ if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() > textOffset))

continuesOnNextLine = false;

}

@@ -798,7 +798,7 @@ Position Position::downstream(EditingBoundaryCrossingRule rule) const

otherBox = otherBox->nextLeafChild();

if (!otherBox)

break;

- if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && static_cast<InlineTextBox*>(otherBox)->start() >= textOffset))

+ if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() >= textOffset))

continuesOnNextLine = false;

}

@@ -807,7 +807,7 @@ Position Position::downstream(EditingBoundaryCrossingRule rule) const

otherBox = otherBox->prevLeafChild();

if (!otherBox)

break;

- if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && static_cast<InlineTextBox*>(otherBox)->start() >= textOffset))

+ if (otherBox == lastTextBox || (otherBox->renderer() == textRenderer && toInlineTextBox(otherBox)->start() >= textOffset))

continuesOnNextLine = false;

}

« no previous file with comments | « Source/core/dom/DocumentMarkerController.cpp ('k') | Source/core/dom/TouchEvent.cpp » ('j') | no next file with comments »