Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1188)

Issue 2424633002: Revert of Mus+Ash: propagate Surface ID to parents (Closed)

Created:
4 years, 2 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mus+Ash: propagate Surface ID to parents (patchset #11 id:200001 of https://codereview.chromium.org/2414683003/ ) Reason for revert: Speculative revert for mash_browser_tests flake Original issue's description: > Mus+Ash: propagate Surface ID to parents > > Currently, in Mus+Ash, the window server is responsible for positioning > windows and generating SurfaceDrawQuads for them. This CL propagates surface > IDs for child windows to their parents so that parents can embed them directly > via CompositorFrames. This will happen in a subsequent patch. > > A SurfaceSequence is allocated for the surface ID that is propagated up the > window hierarchy. As long as the parent holds on to the SurfaceSequence, > then the surface ID will be preserved. Once the parent is informed of a > new surface ID then it will return the SurfaceSequence back to the window > server for reclamation (mus-gpu in the future). If a window is destroyed then > it will also return its SurfaceSequence. > > BUG=647852 > > Committed: https://crrev.com/065bde79d4e511f613ae89a2fc535029dae26100 > Cr-Commit-Position: refs/heads/master@{#425556} TBR=kylechar@chromium.org,rjkroege@chromium.org,sadrul@chromium.org,sky@chromium.org,tsepez@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=647852 Committed: https://crrev.com/c735fc2eda819740138c2a55086cc45ef6d7a9a4 Cr-Commit-Position: refs/heads/master@{#425564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -397 lines) Patch
M services/ui/public/cpp/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D services/ui/public/cpp/surface_id_handler.h View 1 chunk +0 lines, -44 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.h View 1 chunk +0 lines, -2 lines 0 comments Download
M services/ui/public/cpp/tests/test_window_tree.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M services/ui/public/cpp/window.h View 6 chunks +0 lines, -10 lines 0 comments Download
M services/ui/public/cpp/window.cc View 4 chunks +0 lines, -25 lines 0 comments Download
M services/ui/public/cpp/window_private.h View 2 chunks +0 lines, -5 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.h View 2 chunks +0 lines, -8 lines 0 comments Download
M services/ui/public/cpp/window_tree_client.cc View 3 chunks +0 lines, -25 lines 0 comments Download
M services/ui/public/interfaces/window_tree.mojom View 3 chunks +0 lines, -16 lines 0 comments Download
M services/ui/surfaces/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/ui/surfaces/display_compositor.h View 2 chunks +6 lines, -17 lines 0 comments Download
M services/ui/surfaces/display_compositor.cc View 1 chunk +3 lines, -27 lines 0 comments Download
D services/ui/surfaces/display_compositor_client.h View 1 chunk +0 lines, -24 lines 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/server_window_surface.h View 3 chunks +0 lines, -6 lines 0 comments Download
M services/ui/ws/server_window_surface.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M services/ui/ws/test_change_tracker.h View 3 chunks +0 lines, -10 lines 0 comments Download
M services/ui/ws/test_change_tracker.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M services/ui/ws/test_server_window_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M services/ui/ws/test_utils.h View 1 chunk +0 lines, -5 lines 0 comments Download
M services/ui/ws/test_utils.cc View 2 chunks +1 line, -8 lines 0 comments Download
M services/ui/ws/window_server.h View 4 chunks +1 line, -13 lines 0 comments Download
M services/ui/ws/window_server.cc View 2 chunks +1 line, -23 lines 0 comments Download
M services/ui/ws/window_tree.h View 2 chunks +0 lines, -6 lines 0 comments Download
M services/ui/ws/window_tree.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M services/ui/ws/window_tree_client_unittest.cc View 2 chunks +0 lines, -59 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Rockot(use gerrit already)
Created Revert of Mus+Ash: propagate Surface ID to parents
4 years, 2 months ago (2016-10-15 15:40:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2424633002/1
4 years, 2 months ago (2016-10-15 15:41:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-15 15:42:16 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-10-15 15:44:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c735fc2eda819740138c2a55086cc45ef6d7a9a4
Cr-Commit-Position: refs/heads/master@{#425564}

Powered by Google App Engine
This is Rietveld 408576698