Issue 24243013: Fix _XcodeVersion parsing for Xcode 3.2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24243013: Fix _XcodeVersion parsing for Xcode 3.2. (Closed)

Created:
7 years, 3 months ago by tapted

Modified:
7 years, 3 months ago

Reviewers:
Nico

CC:
gyp-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/gyp.git@master

Visibility:
Public.

More Reviews

Description

Fix _XcodeVersion parsing for Xcode 3.2. BUG=295322 gyp r1738

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	pylib/gyp/xcode_emulation.py	View		1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tapted

Hi Nico - WDYT? Not sure if this a configuration we should support.. I have ...

7 years, 3 months ago (2013-09-20 01:37:58 UTC) #1

Nico

lgtm Thanks for the fix! The buildbots use Xcode 3.2 (without .6), and this works ...

7 years, 3 months ago (2013-09-20 03:39:51 UTC) #2

Nico

7 years, 3 months ago (2013-09-20 03:42:30 UTC) #3

On 2013/09/20 03:39:51, Nico wrote:
> lgtm
> 
> Thanks for the fix!
> 
> The buildbots use Xcode 3.2 (without .6), and this works fine there.

Err, the buildbots use Xcode 4.2 (since they are on 10.6). With 3.2.6 you'll
likely run into more issues (the linker in 3.2.6 isn't very good for example
iirc). We don't support 3.2.6.

Landed anyways as it's only a small amount of code. gyp r1738. Thanks again for
the patch!

Expand Messages | Collapse Messages