pylib/gyp/xcode_emulation.py - Issue 24243013: Fix _XcodeVersion parsing for Xcode 3.2. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(639)

My Issues | Starred Open | Closed | All

Unified Diff: pylib/gyp/xcode_emulation.py

Issue 24243013: Fix _XcodeVersion parsing for Xcode 3.2. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pylib/gyp/xcode_emulation.py

diff --git a/pylib/gyp/xcode_emulation.py b/pylib/gyp/xcode_emulation.py

index b4af0fd325044cfaf8482ab828258a05a9aab7fa..0ee46828a4cdc8b3cfb99bb89413dbf61dc27f8e 100644

--- a/pylib/gyp/xcode_emulation.py

+++ b/pylib/gyp/xcode_emulation.py

@@ -768,8 +768,14 @@ class XcodeSettings(object):

# `xcodebuild -version` output looks like

# Xcode 4.6.3

# Build version 4H1503

+ # or like

+ # Xcode 3.2.6

+ # Component versions: DevToolsCore-1809.0; DevToolsSupport-1806.0

+ # BuildVersion: 10M2518

# Convert that to '0463', '4H1503'.

- version, build = self._GetStdout(['xcodebuild', '-version']).splitlines()

+ version_list = self._GetStdout(['xcodebuild', '-version']).splitlines()

+ version = version_list[0]

+ build = version_list[-1]

# Be careful to convert "4.2" to "0420":

version = version.split()[-1].replace('.', '')

version = (version + '0' * (3 - len(version))).zfill(4)

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698