Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 242373002: REGRESSION(r157081): Fix multipart handling of ResourceFetcher (Closed)

Created:
6 years, 8 months ago by Hajime Morrita
Modified:
6 years, 8 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

REGRESSION(r157081): Fix multipart handling of ResourceFetcher r157081 broke multipart handling in ResourceFetcher. The breakage was harmless except Motion JPEG case - ResourceFetcher lost the reference to Motion JPEG resource so it was no longer able to cancel the ongoing resource fetching. This change makes the tracking working again. Also, the change adds a stopFetching() call to DocumentLoder::stopLoading() that is used to be there but was lost at some point. TEST=stop-loading.html R=japhet@chromium.org,abarth@chromium.org BUG=309641 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171969

Patch Set 1 #

Total comments: 1

Patch Set 2 : Landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -8 lines) Patch
A LayoutTests/http/tests/multipart/stop-loading.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/http/tests/multipart/stop-loading-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 2 chunks +8 lines, -7 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Hajime Morrita
PTAL?
6 years, 8 months ago (2014-04-18 00:36:22 UTC) #1
Hajime Morrita
Hey Nate, could you take a look? This fixes a silly mistake I made in ...
6 years, 8 months ago (2014-04-18 18:03:22 UTC) #2
Nate Chapin
LGTM with a question https://codereview.chromium.org/242373002/diff/1/Source/core/loader/DocumentLoader.cpp File Source/core/loader/DocumentLoader.cpp (right): https://codereview.chromium.org/242373002/diff/1/Source/core/loader/DocumentLoader.cpp#newcode193 Source/core/loader/DocumentLoader.cpp:193: m_fetcher->stopFetching(); Is the ordering of ...
6 years, 8 months ago (2014-04-18 18:10:29 UTC) #3
Hajime Morrita
Thanks for the review! > https://codereview.chromium.org/242373002/diff/1/Source/core/loader/DocumentLoader.cpp#newcode193 > Source/core/loader/DocumentLoader.cpp:193: m_fetcher->stopFetching(); > Is the ordering of this ...
6 years, 8 months ago (2014-04-18 18:15:27 UTC) #4
Hajime Morrita
The CQ bit was checked by morrita@chromium.org
6 years, 8 months ago (2014-04-18 18:54:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/morrita@chromium.org/242373002/20001
6 years, 8 months ago (2014-04-18 18:54:52 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-18 20:06:39 UTC) #7
Message was sent while issue was closed.
Change committed as 171969

Powered by Google App Engine
This is Rietveld 408576698