REGRESSION(r157081): Fix multipart handling of ResourceFetcher

Source/core/loader/DocumentLoader.cpp

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 170 matching lines @@
 
     if (m_committed) {
         // Attempt to stop the frame if the document loader is loading, or if it is done loading but
         // still  parsing. Failure to do so can cause a world leak.
         Document* doc = m_frame->document();
 
         if (loading || doc->parsing())
             m_frame->loader().stopLoading();
     }
 
-    if (!loading)
+    if (!loading) {
+        // This is needed to cancel multipart loading which can be happening even after the frame is loaded.
+        m_fetcher->stopFetching();

[Nate Chapin, 2014/04/18 18:10:29]

Is the ordering of this call important? If not, I'd favor moving this
stopFetching() call above this if() block and removing the stopFetching() call
at the end of the function.

         return;
+    }
 
     if (m_loadingMainResource) {
         // Stop the main resource loader and let it send the cancelled message.
         cancelMainResourceLoad(ResourceError::cancelledError(m_request.url()));
     } else if (m_fetcher->isFetching()) {
         // The main resource loader already finished loading. Set the cancelled error on the
         // document and let the resourceLoaders send individual cancelled messages below.
         setMainDocumentError(ResourceError::cancelledError(m_request.url()));
     } else {
         // If there are no resource loaders, we need to manufacture a cancelled message.
@@ skipping 625 matching lines @@
 void DocumentLoader::replaceDocument(const String& source, Document* ownerDocument)
 {
     m_frame->loader().stopAllLoaders();
     m_writer = createWriterFor(m_frame, ownerDocument, m_frame->document()->url(), mimeType(), m_writer ? m_writer->encoding() : emptyAtom,  m_writer ? m_writer->encodingWasChosenByUser() : false, true);
     if (!source.isNull())
         m_writer->appendReplacingData(source);
     endWriting(m_writer.get());
 }
 
 } // namespace WebCore