Implement finished reason and exception for BidirectionalStream

Implement finished reason and exception for BidirectionalStream

BUG=629194
Committed: https://crrev.com/30caafb88a220a9352c7940d9d8b14070ef5d1f5
Cr-Commit-Position: refs/heads/master@{#425794}

[mgersh, 2016-10-17 19:48:33]

mgersh@chromium.org changed reviewers:
+ xunjieli@chromium.org

[mgersh, 2016-10-17 19:48:34]

PTAL

[xunjieli, 2016-10-17 21:33:43]

lgtm with nits

https://codereview.chromium.org/2422993004/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java
(right):

https://codereview.chromium.org/2422993004/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java:651:
throw new IllegalStateException("Unexpected state when collecting metrics.");
Instead of doing a runtime exception that can't be turned off, could you do an
"assert mReadState == mWriteState" at the start, and then do if-conditionals on
|mReadState| ?

[mgersh, 2016-10-17 22:20:45]

https://codereview.chromium.org/2422993004/diff/1/components/cronet/android/j...
File
components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java
(right):

https://codereview.chromium.org/2422993004/diff/1/components/cronet/android/j...
components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java:651:
throw new IllegalStateException("Unexpected state when collecting metrics.");
On 2016/10/17 21:33:43, xunjieli wrote:
> Instead of doing a runtime exception that can't be turned off, could you do an
> "assert mReadState == mWriteState" at the start, and then do if-conditionals
on
> |mReadState| ?

Done.

[mgersh, 2016-10-17 22:20:51]

The CQ bit was checked by mgersh@chromium.org

[mgersh, 2016-10-17 22:20:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
xunjieli@chromium.org
Link to the patchset: https://codereview.chromium.org/2422993004/#ps20001
(title: "Change IllegalStateException to asserts")

[commit-bot: I haz the power, 2016-10-17 22:21:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 22:34:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-17 22:37:04]

Description was changed from

==========
Implement finished reason and exception for BidirectionalStream

BUG=629194
==========

to

==========
Implement finished reason and exception for BidirectionalStream

BUG=629194

Committed: https://crrev.com/30caafb88a220a9352c7940d9d8b14070ef5d1f5
Cr-Commit-Position: refs/heads/master@{#425794}
==========

[commit-bot: I haz the power, 2016-10-17 22:37:05]

Patchset 2 (id:??) landed as
https://crrev.com/30caafb88a220a9352c7940d9d8b14070ef5d1f5
Cr-Commit-Position: refs/heads/master@{#425794}