components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java - Issue 2422993004: Implement finished reason and exception for BidirectionalStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

Issue 2422993004: Implement finished reason and exception for BidirectionalStream (Closed)

Patch Set: Change IllegalStateException to asserts Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

diff --git a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

index bda19719e3e006998e6afce742ad73520afa93ec..dcca5aa40414efb634231bcbac95b6e6543a7add 100644

--- a/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

+++ b/components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java

@@ -712,7 +712,6 @@ public final class CronetUrlRequest implements UrlRequest {

}

private RequestFinishedInfo getRequestFinishedInfo() {

- // TODO(mgersh): fill in real values for finishedReason and exception

return new RequestFinishedInfo(mInitialUrl, mRequestAnnotations, mMetrics, mFinishedReason,

mResponseInfo, mException);

}