Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

Issue 2422993004: Implement finished reason and exception for BidirectionalStream (Closed)
Patch Set: Change IllegalStateException to asserts Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
index 100546ef91b1cd36b2c13a9add543b4b14a92ad5..57b4dc4a3641bb956d70cda730aae1070f96e746 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
@@ -1200,6 +1200,13 @@ public class BidirectionalStreamTest extends CronetTestBase {
}
assertEquals(expectError, callback.mError != null);
assertEquals(expectError, callback.mOnErrorCalled);
+ if (expectError) {
+ assertNotNull(finishedInfo.getException());
+ assertEquals(RequestFinishedInfo.FAILED, finishedInfo.getFinishedReason());
+ } else {
+ assertNull(finishedInfo.getException());
+ assertEquals(RequestFinishedInfo.CANCELED, finishedInfo.getFinishedReason());
+ }
assertEquals(failureType == FailureType.CANCEL_SYNC
|| failureType == FailureType.CANCEL_ASYNC
|| failureType == FailureType.CANCEL_ASYNC_WITHOUT_PAUSE,
« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698