Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Issue 2422933002: Reduce usage of FOR_EACH_OBSERVER macro in content/ (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, Peter Beverloo, jam, ortuno+watch_chromium.org, scheib+watch_chromium.org, darin-cc_chromium.org, blink-worker-reviews_chromium.org, einbinder+watch-test-runner_chromium.org, kinuko+watch, jochen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce usage of FOR_EACH_OBSERVER macro in content/ Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/6a42e2c8fdb718662a45a8c8d93327fdf9ea6c53 Cr-Commit-Position: refs/heads/master@{#425603}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -36 lines) Patch
M content/child/worker_thread_registry.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/test/mock_download_item.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc View 5 chunks +20 lines, -21 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eric Willigers
4 years, 2 months ago (2016-10-17 00:54:07 UTC) #6
Avi (use Gerrit)
lgtm drive by
4 years, 2 months ago (2016-10-17 00:59:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422933002/1
4 years, 2 months ago (2016-10-17 01:31:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 01:36:03 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 01:38:02 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a42e2c8fdb718662a45a8c8d93327fdf9ea6c53
Cr-Commit-Position: refs/heads/master@{#425603}

Powered by Google App Engine
This is Rietveld 408576698