Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2236)

Unified Diff: content/public/test/mock_render_process_host.cc

Issue 2422933002: Reduce usage of FOR_EACH_OBSERVER macro in content/ (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/mock_render_process_host.cc
diff --git a/content/public/test/mock_render_process_host.cc b/content/public/test/mock_render_process_host.cc
index b6337d36c6e2b721fb8e00f099b25b76fe3b1bc2..403bc3c0e82682e4f164c863967c7f3e9076f9df 100644
--- a/content/public/test/mock_render_process_host.cc
+++ b/content/public/test/mock_render_process_host.cc
@@ -57,9 +57,8 @@ MockRenderProcessHost::~MockRenderProcessHost() {
// In unit tests, Cleanup() might not have been called.
if (!deletion_callback_called_) {
- FOR_EACH_OBSERVER(RenderProcessHostObserver,
- observers_,
- RenderProcessHostDestroyed(this));
+ for (auto& observer : observers_)
+ observer.RenderProcessHostDestroyed(this);
RenderProcessHostImpl::UnregisterHost(GetID());
}
}
@@ -72,9 +71,8 @@ void MockRenderProcessHost::SimulateCrash() {
NOTIFICATION_RENDERER_PROCESS_CLOSED, Source<RenderProcessHost>(this),
Details<RenderProcessHost::RendererClosedDetails>(&details));
- FOR_EACH_OBSERVER(
- RenderProcessHostObserver, observers_,
- RenderProcessExited(this, details.status, details.exit_code));
+ for (auto& observer : observers_)
+ observer.RenderProcessExited(this, details.status, details.exit_code);
// Send every routing ID a FrameHostMsg_RenderProcessGone message. To ensure a
// predictable order for unittests which may assert against the order, we sort
@@ -204,9 +202,8 @@ bool MockRenderProcessHost::IgnoreInputEvents() const {
void MockRenderProcessHost::Cleanup() {
if (listeners_.IsEmpty()) {
- FOR_EACH_OBSERVER(RenderProcessHostObserver,
- observers_,
- RenderProcessHostDestroyed(this));
+ for (auto& observer : observers_)
+ observer.RenderProcessHostDestroyed(this);
base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
RenderProcessHostImpl::UnregisterHost(GetID());
deletion_callback_called_ = true;
« no previous file with comments | « content/public/test/mock_download_item.cc ('k') | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698