Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2422403003: Disable WebUSB detector logic on Windows. (Closed)

Created:
4 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
juncai
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable WebUSB detector logic on Windows. Initializing the WebUSB device detector logic causes the USB subsystem to attempt to fully enumerate the system's USB bus. This has been found to cause jank and hangs on Chrome's FILE thread on Windows. Disabling this component of WebUSB while the issue is investigated. WebUSB will continue to function but this change will prevent the issue from impacting users who do not visit sites using it. BUG=656702 TEST=Verified USB subsystem is not initialized on startup on Windows by checking chrome://device-log. Verified still initialized on Linux. Committed: https://crrev.com/dfd32df76aea1a2d4f1aad69c74ded742a2ac69b Cr-Commit-Position: refs/heads/master@{#425867}

Patch Set 1 #

Patch Set 2 : Disable WebUSB detector unit tests on Windows. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/usb/web_usb_detector.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/usb/web_usb_detector_unittest.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Reilly Grant (use Gerrit)
Please take a look. This will be merged to the M-54 and M-55 branches.
4 years, 2 months ago (2016-10-18 00:11:27 UTC) #2
juncai
LGTM.
4 years, 2 months ago (2016-10-18 00:30:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422403003/1
4 years, 2 months ago (2016-10-18 00:38:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/299637)
4 years, 2 months ago (2016-10-18 01:53:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422403003/20001
4 years, 2 months ago (2016-10-18 02:07:01 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-18 02:42:40 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 02:46:19 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dfd32df76aea1a2d4f1aad69c74ded742a2ac69b
Cr-Commit-Position: refs/heads/master@{#425867}

Powered by Google App Engine
This is Rietveld 408576698