Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: chrome/browser/usb/web_usb_detector_unittest.cc

Issue 2422403003: Disable WebUSB detector logic on Windows. (Closed)
Patch Set: Disable WebUSB detector unit tests on Windows. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/usb/web_usb_detector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/usb/web_usb_detector_unittest.cc
diff --git a/chrome/browser/usb/web_usb_detector_unittest.cc b/chrome/browser/usb/web_usb_detector_unittest.cc
index 70b5f4c6ea4386c2164861360ad86c6d28f41a97..dd410a289278e9dd92a7b055d1422952b548b174 100644
--- a/chrome/browser/usb/web_usb_detector_unittest.cc
+++ b/chrome/browser/usb/web_usb_detector_unittest.cc
@@ -17,6 +17,10 @@
#include "ui/message_center/notification_delegate.h"
#include "url/gurl.h"
+// These tests are disabled because WebUsbDetector::Initialize is a noop on
+// Windows due to jank and hangs caused by enumerating devices.
+// https://crbug.com/656702
+#if !defined(OS_WIN)
namespace {
// USB device product name.
@@ -399,3 +403,4 @@ TEST_F(WebUsbDetectorTest, ThreeUsbDeviceAddedAndRemovedDifferentOrder) {
device_client_.usb_service()->RemoveDevice(device_3);
EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_3));
}
+#endif // !OS_WIN
« no previous file with comments | « chrome/browser/usb/web_usb_detector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698