Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: chrome/browser/usb/web_usb_detector.cc

Issue 2422403003: Disable WebUSB detector logic on Windows. (Closed)
Patch Set: Disable WebUSB detector unit tests on Windows. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/usb/web_usb_detector_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/usb/web_usb_detector.cc
diff --git a/chrome/browser/usb/web_usb_detector.cc b/chrome/browser/usb/web_usb_detector.cc
index bc597c84c8eb9dea81eb648a24a23e03ceecaf31..07c3a3b1cbf19647920f1f1173a8af811232ffdd 100644
--- a/chrome/browser/usb/web_usb_detector.cc
+++ b/chrome/browser/usb/web_usb_detector.cc
@@ -118,6 +118,9 @@ WebUsbDetector::WebUsbDetector() : observer_(this) {}
WebUsbDetector::~WebUsbDetector() {}
void WebUsbDetector::Initialize() {
+// Disabled on Windows due to jank and hangs caused by enumerating devices.
+// https://crbug.com/656702
+#if !defined(OS_WIN)
SCOPED_UMA_HISTOGRAM_TIMER("WebUsb.DetectorInitialization");
device::UsbService* usb_service =
device::DeviceClient::Get()->GetUsbService();
@@ -125,6 +128,7 @@ void WebUsbDetector::Initialize() {
return;
observer_.Add(usb_service);
+#endif
}
void WebUsbDetector::OnDeviceAdded(scoped_refptr<device::UsbDevice> device) {
« no previous file with comments | « no previous file | chrome/browser/usb/web_usb_detector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698