Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: third_party/WebKit/Source/core/editing/EditingStyle.cpp

Issue 2422133002: Audit use of updateStyleAndLayoutIgnorePendingStylesheets in EditingStyle::removeStyleFromRulesAndC… (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditingStyle.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingStyle.cpp b/third_party/WebKit/Source/core/editing/EditingStyle.cpp
index 70589eceaab327bf6aa9a0be860ad286cc23bf83..c70d8ca33d64266275b714ed452ee46240e812ff 100644
--- a/third_party/WebKit/Source/core/editing/EditingStyle.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingStyle.cpp
@@ -1413,10 +1413,9 @@ void EditingStyle::removeStyleFromRulesAndContext(Element* element,
if (!m_mutableStyle)
return;
- // TODO(yosin): The use of updateStyleAndLayoutIgnorePendingStylesheets
- // needs to be audited. see http://crbug.com/590369 for more details.
- element->document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(
- element);
+ // StyleResolver requires clean style.
+ DCHECK_GE(element->document().lifecycle().state(),
yosin_UTC9 2016/10/17 09:45:18 Could you add DCHECK(element->document().lifecylce
Xiaocheng 2016/10/17 10:07:27 Thanks for the catch. Done.
+ DocumentLifecycle::StyleClean);
// 1. Remove style from matched rules because style remain without repeating
// it in inline style declaration

Powered by Google App Engine
This is Rietveld 408576698