Audit use of updateStyleAndLayoutIgnorePendingStylesheets in EditingStyle::removeStyleFromRulesAndC…

third_party/WebKit/Source/core/editing/EditingStyle.cpp

 /*
  * Copyright (C) 2007, 2008, 2009 Apple Computer, Inc.
  * Copyright (C) 2010, 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1395 matching lines @@
   styleToRemovePropertiesFrom->removePropertiesInSet(propertiesToRemove.data(),
                                                      propertiesToRemove.size());
 }
 
 void EditingStyle::removeStyleFromRulesAndContext(Element* element,
                                                   ContainerNode* context) {
   DCHECK(element);
   if (!m_mutableStyle)
     return;
 
-  // TODO(yosin): The use of updateStyleAndLayoutIgnorePendingStylesheets
-  // needs to be audited. see http://crbug.com/590369 for more details.
-  element->document().updateStyleAndLayoutIgnorePendingStylesheetsForNode(
-      element);
+  // StyleResolver requires clean style.
+  DCHECK_GE(element->document().lifecycle().state(),

[yosin_UTC9, 2016/10/17 09:45:18]

Could you add DCHECK(element->document().lifecylce().isActive()) for just in
case?
Since, Stopping and Stopped is grater than StyleClean. :-<

[Xiaocheng, 2016/10/17 10:07:27]

Thanks for the catch. Done.

+            DocumentLifecycle::StyleClean);
 
   // 1. Remove style from matched rules because style remain without repeating
   // it in inline style declaration
   MutableStylePropertySet* styleFromMatchedRules =
       styleFromMatchedRulesForElement(element,
                                       StyleResolver::AllButEmptyCSSRules);
   if (styleFromMatchedRules && !styleFromMatchedRules->isEmpty())
     m_mutableStyle =
         getPropertiesNotIn(m_mutableStyle.get(),
                            styleFromMatchedRules->ensureCSSStyleDeclaration());
@@ skipping 610 matching lines @@
   for (Node* ancestor = node; ancestor; ancestor = ancestor->parentNode()) {
     CSSComputedStyleDeclaration* ancestorStyle =
         CSSComputedStyleDeclaration::create(ancestor);
     if (!hasTransparentBackgroundColor(ancestorStyle))
       return ancestorStyle->getPropertyCSSValue(CSSPropertyBackgroundColor);
   }
   return nullptr;
 }
 
 }  // namespace blink