Audit use of updateStyleAndLayoutIgnorePendingStylesheets in EditingStyle::removeStyleFromRulesAndC…

third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp

Index: third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
index 30d84ca27f9c60e0cd0712637de6c186fe31ef23..ba019618bc04bc9321c7a118efabab1c553ec850 100644
--- a/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/ReplaceSelectionCommand.cpp
@@ -606,6 +606,11 @@ void ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline(
               : toHTMLQuoteElement(enclosingNodeOfType(
                     Position::firstPositionInNode(context),
                     isMailHTMLBlockquoteElement, CanCrossEditingBoundary));
+
+      // EditingStyle::removeStyleFromRulesAndContext() uses StyleResolver,
+      // which requires clean style.
+      document().updateStyleAndLayoutIgnorePendingStylesheets();

[yosin_UTC9, 2016/10/17 09:45:18]

Should we call Document::updateStyle() instead of
updateStyleAndLayoutIgnorePendingStyleSheets() since a comment above says it for
StyleResolver.

[Xiaocheng, 2016/10/17 10:07:27]

Document::updateStyle is private...

[yosin_UTC9, 2016/10/18 01:40:19]

Could you leave TODO comment that we need to update only style w/ ignoring
pending style sheets?

It seems current implementation of Document::updateStyle() isn't ready for
calling out side Document::updateStyleAndLayout().
We need to do following before calling updateStyle():
  DocumentAnimations::updateAnimationTimingIfNeeded(*this);
  evaluateMediaQueryListIfNeeded();
  updateUseShadowTreesIfNeeded();
  updateDistribution();
  updateStyleInvalidationIfNeeded();

We might want to have updateLifcycleToStyleClean() similar to
FrameView::updateLifecylceToLayoutClean() in Document.

+
       if (blockquoteElement)
         newInlineStyle->removeStyleFromRulesAndContext(
             element, document().documentElement());