Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1473)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutGrid.cpp

Issue 2421593002: [css-grid] Constrain by min-height on auto-repeat computation (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutGrid.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
index 2b40465d3599ba4efff6b6b75a6f8cf3c81b7755..aa2938aadab5cdeae7d7b7fad064feb5fe69fe9c 100644
--- a/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
@@ -1790,12 +1790,11 @@ size_t LayoutGrid::computeAutoRepeatTracksCount(
availableSize = availableLogicalHeightForPercentageComputation();
if (availableSize == -1) {
const Length& maxLength = styleRef().logicalMaxHeight();
- if (!maxLength.isMaxSizeNone())
- availableSize =
- computeContentLogicalHeight(MaxSize, maxLength, LayoutUnit(-1));
- } else {
- availableSize =
- constrainLogicalHeightByMinMax(availableSize, LayoutUnit(-1));
+ if (!maxLength.isMaxSizeNone()) {
+ availableSize = constrainContentBoxLogicalHeightByMinMax(
+ availableLogicalHeightUsing(maxLength, ExcludeMarginBorderPadding),
+ LayoutUnit(-1));
+ }
}
jfernandez 2016/10/13 21:21:08 Why the availableLogicalHeightForPercentageComputa
svillar 2016/10/14 12:46:37 Because that method already does it while availabl
}

Powered by Google App Engine
This is Rietveld 408576698