Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-rows.html

Issue 2421593002: [css-grid] Constrain by min-height on auto-repeat computation (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-rows.html
diff --git a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-rows.html b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-rows.html
index ef6c6ecbc7f8868974475fc7f57e35e1bc69e364..e6f3601057209acd4b31e04922a3b987ee8a772c 100644
--- a/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-rows.html
+++ b/third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-auto-fill-rows.html
@@ -23,7 +23,9 @@
.gridMultipleNames { grid-template-rows: [start] 20px [foo] 50% repeat(auto-fill, [bar] 20px [start foo]) [foo] 10% [end bar]; }
.gridMultipleTracks { grid-template-rows: [start] 20px repeat(auto-fill, [a] 2em [b c] 10% [d]) [e] minmax(75px, 1fr) [last]; }
-.item { background-color: cyan; }
+.item { background-color: blue; }
+.item:nth-child(2) { background: green; }
+.item:nth-child(3) { background: orange; }
.gap { grid-row-gap: 20px; }
@@ -54,6 +56,18 @@
<div class="item" style="grid-row: autobar 2 / span 3" data-offset-y="100" data-offset-x="0" data-expected-height="257" data-expected-width="25"></div>
</div>
+<div class="grid gridOnlyAutoRepeat gap" style="height: auto; max-height: 90px;" data-expected-height="94" data-expected-width="29">
+ <div class="item" data-offset-y="0" data-offset-x="0" data-expected-height="30" data-expected-width="25"></div>
+ <div class="item" data-offset-y="50" data-offset-x="0" data-expected-height="30" data-expected-width="25"></div>
+ <div class="item" data-offset-y="100" data-offset-x="0" data-expected-height="157" data-expected-width="25"></div>
+</div>
+
+<div class="grid gridOnlyAutoRepeat gap" style="height: auto; max-height: 90px; min-height: 130px;" data-expected-height="134" data-expected-width="29">
+ <div class="item" data-offset-y="0" data-offset-x="0" data-expected-height="30" data-expected-width="25"></div>
+ <div class="item" data-offset-y="50" data-offset-x="0" data-expected-height="30" data-expected-width="25"></div>
+ <div class="item" data-offset-y="100" data-offset-x="0" data-expected-height="30" data-expected-width="25"></div>
+</div>
Manuel Rego 2016/10/14 08:10:19 Wouldn't be nice to have the same tests for column
svillar 2016/10/14 12:46:36 OK I can add them too.
+
<div class="grid gridAutoRepeatAndFixedBefore">
<div class="item" style="grid-row: 1 / span 6" data-offset-y="0" data-offset-x="0" data-expected-height="190" data-expected-width="25"></div>
</div>

Powered by Google App Engine
This is Rietveld 408576698