[css-grid] Constrain by min-height on auto-repeat computation

third_party/WebKit/Source/core/layout/LayoutGrid.cpp

 /*
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1772 matching lines @@
 
   LayoutUnit availableSize;
   if (isRowAxis) {
     availableSize = sizingOperation == IntrinsicSizeComputation
                         ? LayoutUnit(-1)
                         : availableLogicalWidth();
   } else {
     availableSize = availableLogicalHeightForPercentageComputation();
     if (availableSize == -1) {
       const Length& maxLength = styleRef().logicalMaxHeight();
-      if (!maxLength.isMaxSizeNone())
-        availableSize =
-            computeContentLogicalHeight(MaxSize, maxLength, LayoutUnit(-1));
-    } else {
-      availableSize =
-          constrainLogicalHeightByMinMax(availableSize, LayoutUnit(-1));
+      if (!maxLength.isMaxSizeNone()) {
+        availableSize = constrainContentBoxLogicalHeightByMinMax(
+            availableLogicalHeightUsing(maxLength, ExcludeMarginBorderPadding),
+            LayoutUnit(-1));
+      }
     }

[jfernandez, 2016/10/13 21:21:08]

Why the availableLogicalHeightForPercentageComputation value, if valid, does not
need to be constrained between min/max limits ?

[svillar, 2016/10/14 12:46:37]

Because that method already does it while availableLogicalHeightUsing() does
not.

   }
 
   bool needsToFulfillMinimumSize = false;
   bool indefiniteMainAndMaxSizes = availableSize == LayoutUnit(-1);
   if (indefiniteMainAndMaxSizes) {
     const Length& minSize = isRowAxis ? styleRef().logicalMinWidth()
                                       : styleRef().logicalMinHeight();
     if (!minSize.isSpecified())
       return autoRepeatTrackListLength;
 
@@ skipping 1517 matching lines @@
   if (!m_gridItemArea.isEmpty())
     GridPainter(*this).paintChildren(paintInfo, paintOffset);
 }
 
 bool LayoutGrid::cachedHasDefiniteLogicalHeight() const {
   SECURITY_DCHECK(m_hasDefiniteLogicalHeight);
   return m_hasDefiniteLogicalHeight.value();
 }
 
 }  // namespace blink