Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 242135: Merge r25564 and r26588 from the trunk.... (Closed)

Created:
11 years, 2 months ago by wtc
Modified:
9 years, 7 months ago
Reviewers:
laforge
CC:
chromium-reviews_googlegroups.com, darin (slow to review), willchan no longer on Chromium
Visibility:
Public.

Description

Merge r25564 and r26588 from the trunk. r25564: Use SSPI for NTLM authentication on Windows. Add an explicit embedded_identity_used_ boolean member to make sure we use the username/password in the URL only once for the transaction. This allows us to reset auth_identity_[target].source to HttpAuth::IDENT_SRC_NONE after auth failed. Initial patch by Arindam. Original review URL: http://codereview.chromium.org/159656 r26588: We should pass the service principal name (SPN) of the format "HTTP/host:port" as the third argument (pszTargetName) to InitializeSecurityContext. This requires adding an origin parameter to some methods. Remove obsolete (and incorrect) logging code in HttpNetworkTransaction::PrepareForAuthRestart(). R=laforge BUG=19, 18009, 20560 TEST=1. Open a webpage that requests NTLM authentication on Windows. 2. New unit test for wrong auth identity in URL. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28078

Patch Set 1 #

Patch Set 2 : Undo an extraneous comment change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -845 lines) Patch
M net/http/http_auth.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M net/http/http_auth.cc View 1 5 chunks +5 lines, -3 lines 0 comments Download
M net/http/http_auth_handler.h View 1 3 chunks +12 lines, -2 lines 0 comments Download
M net/http/http_auth_handler.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M net/http/http_auth_handler_basic_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_auth_handler_digest_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_auth_handler_ntlm.h View 1 6 chunks +38 lines, -3 lines 0 comments Download
M net/http/http_auth_handler_ntlm.cc View 1 4 chunks +3 lines, -687 lines 0 comments Download
A + net/http/http_auth_handler_ntlm_portable.cc View 4 chunks +6 lines, -91 lines 0 comments Download
A net/http/http_auth_handler_ntlm_win.cc View 1 chunk +193 lines, -0 lines 0 comments Download
M net/http/http_auth_unittest.cc View 1 8 chunks +10 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M net/http/http_network_transaction.cc View 1 10 chunks +24 lines, -55 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 4 chunks +119 lines, -1 line 0 comments Download
M net/net.gyp View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
wtc
Anthony, please approve this merge to the 195 branch.
11 years, 2 months ago (2009-10-03 00:16:55 UTC) #1
laforge
11 years, 2 months ago (2009-10-05 18:37:05 UTC) #2
On 2009/10/03 00:16:55, wtc wrote:
> Anthony, please approve this merge to the 195 branch.

LGTM

Powered by Google App Engine
This is Rietveld 408576698