Include SSPI support for NTLM authentication.

[Replaced by http://codereview.chromium.org/173528 ]

Include SSPI support for NTLM authentication [windows only].

TEST=open a NTLM authorized webpage in windows
BUG=http://crbug/19, http://crbug/18009

[Arindam, 2009-07-31 01:41:44]

The unittests (gtest_filter=*NTLM*) on windows do not run any more. I am
investigating that issue.
Please have a look otherwise.

[wtc, 2009-08-04 00:45:10]

http://codereview.chromium.org/159656/diff/1020/1026
File net/http/http_auth_handler_ntlm.h (right):

http://codereview.chromium.org/159656/diff/1020/1026#newcode14
Line 14: #include "net/base/net_errors.h"
Nit: list this header before "net/http/http_auth_handler.h",

http://codereview.chromium.org/159656/diff/1020/1026#newcode93
Line 93: protected:
Rather than adding 'protected' here, let's move these data
members up to the protected section.

See
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Declaration_Order

http://codereview.chromium.org/159656/diff/1020/1021
File net/http/http_auth_handler_ntlm_win.cc (right):

http://codereview.chromium.org/159656/diff/1020/1021#newcode9
Line 9: 
The following comment assumes that you copied Mozilla code.
If you didn't, please ignore this entire comment.

You need to copy the license header from the Mozilla files
because you copied the code.

Please also add a comment to note the CVS or Hg revision
of the Mozilla file that you copied.  This will help us
in the future if we need to merge new versions of that
file.

In this particular case, since the code is very simple,
we probably won't ever merge new versions of that file.
But it's a good practice to document the revision of the
file.

http://codereview.chromium.org/159656/diff/1020/1021#newcode47
Line 47: memset(&cred_, 0, sizeof(cred_));
It's not necessary to zero cred_ in the destructor.

http://codereview.chromium.org/159656/diff/1020/1021#newcode158
Line 158: if (rc == SEC_I_CONTINUE_NEEDED || rc == SEC_E_OK) {
Could you find out if we actually get rc == SEC_I_CONTINUE_NEEDED here?

http://codereview.chromium.org/159656/diff/1020/1021#newcode166
Line 166: } else {
Nit: don't use 'else' after a return statement.

http://codereview.chromium.org/159656/diff/1020/1024
File net/http/http_auth_handler_ntlm_win.h (right):

http://codereview.chromium.org/159656/diff/1020/1024#newcode23
Line 23: // NTLM implementation that uses SSPI. It uses as much code possible
from the
Nit: add "as" before "possible".

Do we need to use SSPI's Encrypt and Decrypt functions?

http://codereview.chromium.org/159656/diff/1020/1024#newcode25
Line 25: class HttpAuthHandlerNTLMWin : public HttpAuthHandlerNTLM {
We shouldn't derive HttpAuthHandlerNTLMWin from
HttpAuthHandlerNTLM like this because some of the
HttpAuthHandlerNTLM code will be dead code on Windows.

Perhaps the right solution is to split HttpAuthHandlerNTLM
into two classes, like the Mozilla code.  Actually we used
to have two classes, too.  I merged them in r12290.  So
you may want to undo that part of r12290 first, and then
add a NTLMAuthModuleWin class that calls SSPI.

http://codereview.chromium.org/159656/diff/1020/1024#newcode32
Line 32: // This must be called once before any calls to GetNextToken can be
done.
This comment should be moved to http_auth_handler_ntlm.h.

http://codereview.chromium.org/159656/diff/1020/1023
File net/http/http_auth_handler_ntlm_win_unittest.cc (right):

http://codereview.chromium.org/159656/diff/1020/1023#newcode1
Line 1: // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
Nit: new files added this year should just say "2009".

http://codereview.chromium.org/159656/diff/1020/1023#newcode6
Line 6: #include "net/http/http_auth_handler_ntlm_win.h"
You probably don't need to include "base/ref_counted.h"
and "testing/platform_test.h".

http://codereview.chromium.org/159656/diff/1020/1027
File net/net.gyp (right):

http://codereview.chromium.org/159656/diff/1020/1027#newcode220
Line 220: 'http/http_auth_handler_ntlm.cc',
I believe we also need to exclude
http_auth_handler_ntlm.{cc,h} from the 'sources' list on
Windows.

[wtc, 2009-08-04 00:53:58]

Rather than splitting the class into two classes, another
idea is to define the Init and GetNextToken classes in
platform-specific files (_win.cc and _posix.cc or _portable.cc).  For an
example, take a look at the
x509_certificate.h class.  We have several .cc files for
x509_certificate: x509_certificate.cc for the methods common
to all platforms, and x509_certificate_win/mac/nss.cc for
methods that have platform-specific implementations.